Skip to content

Conversation

@IgorChvyrov-sm
Copy link
Contributor

@IgorChvyrov-sm IgorChvyrov-sm commented Sep 23, 2025

Changes:

Added helper method is available to determine if the workflow is currently running.
Added helper method is available to retrieve the currently in-progress task(s).
Added helper method is available to get a task by its reference name.
Added helper method is available to determine if the workflow has failed
Added unit tests

Note: This PR is fixing is_successful() method. Originally it was using self._status (non-existent attribute) instead of self.status

@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nductor/client/adapters/models/workflow_adapter.py 96.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
...asyncio_client/adapters/models/workflow_adapter.py 96.07% <100.00%> (+19.41%) ⬆️
...ctor/asyncio_client/configuration/configuration.py 97.67% <ø> (-2.33%) ⬇️
src/conductor/client/adapters/rest_adapter.py 92.96% <ø> (-7.04%) ⬇️
...nductor/client/adapters/models/workflow_adapter.py 97.91% <96.66%> (-2.09%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IgorChvyrov-sm IgorChvyrov-sm marked this pull request as ready for review September 23, 2025 14:00
@IgorChvyrov-sm IgorChvyrov-sm changed the title Feature workflow model helper methods Enhance Workflow Model with Helper Methods Sep 23, 2025
Copy link

@nthmost-orkes nthmost-orkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, we should get this into a release ASAP. ✨

@nthmost-orkes
Copy link

Might be useful to note in the PR description that this fixes the is_successful() method which was incorrectly referencing self._status (non-existent attribute) instead of self.status - this would have caused AttributeError in
production.

Did we have an issue or JIRA ticket for that?

@IgorChvyrov-sm
Copy link
Contributor Author

Might be useful to note in the PR description that this fixes the is_successful() method which was incorrectly referencing self._status (non-existent attribute) instead of self.status - this would have caused AttributeError in production.

Did we have an issue or JIRA ticket for that?

I've added information about this fix to PR description. Regarding ticket, we didn't have one.

@IgorChvyrov-sm IgorChvyrov-sm changed the base branch from feature_add_ssl_options to main October 8, 2025 13:03
@IgorChvyrov-sm IgorChvyrov-sm merged commit 1282662 into main Oct 8, 2025
2 checks passed
from conductor.client.codegen.models.workflow import Workflow


class WorkflowAdapter(Workflow):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know a bit late, but why do we need this class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants