-
Notifications
You must be signed in to change notification settings - Fork 39
Enhance Workflow Model with Helper Methods #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s and moved shared enums
This reverts commit cb9fc88.
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
nthmost-orkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, we should get this into a release ASAP. ✨
|
Might be useful to note in the PR description that this fixes the Did we have an issue or JIRA ticket for that? |
I've added information about this fix to PR description. Regarding ticket, we didn't have one. |
| from conductor.client.codegen.models.workflow import Workflow | ||
|
|
||
|
|
||
| class WorkflowAdapter(Workflow): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know a bit late, but why do we need this class?
Changes:
Added helper method is available to determine if the workflow is currently running.
Added helper method is available to retrieve the currently in-progress task(s).
Added helper method is available to get a task by its reference name.
Added helper method is available to determine if the workflow has failed
Added unit tests
Note: This PR is fixing
is_successful()method. Originally it was usingself._status(non-existent attribute) instead ofself.status