-
Notifications
You must be signed in to change notification settings - Fork 304
Follow the chain of paths for local dependencies #337
Follow the chain of paths for local dependencies #337
Conversation
|
Include fix from #336 |
|
@visionmedia > Let me know if you wanna me to do any change on this |
|
hmm a test would be good if possible, locals were not influenced by the parent's |
|
Will make a test then. |
|
@visionmedia Added a test to replicate our problem |
Conflicts: lib/component.js
|
+1 I just ran into this problem and merging in this branch solves it for me. |
|
@dominicbarnes I'm glad it fixed your problem |
|
test doesn't pass (missing component.json) but ill take a look |
|
Weird, I may have messed up during a merge or something. |
|
still fails for me, there's no component.json: |
|
It's not like I wanna to pression on @visionmedia but this is getting old. |
|
well this is causing me more work than just fixing it haha, usually people run their own tests first :p |
|
Oh! The file was ignored by git. Pushing now |
|
damn, still missing the other ones, master has |
|
Git didn't see those even with the .gitignore update. On Jun 19, 2013, at 9:04, TJ Holowaychuk [email protected] wrote: damn, still missing the other ones, master has — |
|
Sorry for the delay, I had to do it from my phone |
|
hahaha that can't be too easy, thanks man |
|
What is the status on this fix? I don't see it ever being merged? |
|
It's in since v0.16.4 |
|
I am still seeing this issue while running on latest, should I open a new issue? |
|
Not having any problems on my side. You sure all your paths are correct? |
Look for local chain of dependencies based on parent dependencies path list.
Kept the pathfrom the root
component.jsonduring the lookup for backward compatibility