-
-
Notifications
You must be signed in to change notification settings - Fork 71
Add summary emails #1662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add summary emails #1662
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions incoming shortly - it also seems it's the first time we've ever tried to pass ActiveRecord::Relation as a parameter to .with( - which I believe is not a supported type? Seems to be corroborated by the "Unsupported argument type: ActiveRecord::Relation" error when trying to implement tests.
…relations (not serializable)
Suggestions for PR #1662
|
tsck, seems like mail delivery test might need better isolation (or maybe not, the pipeline only complains about the recipient's email), CircleCI didn't like the merged version at all. Initially. Must be flaky. Yup, definitely flaky. |
Oaphi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds content summary emails sent to staff. Helps in raising our email volume to avoid AWS issues...