-
-
Notifications
You must be signed in to change notification settings - Fork 71
Fix numeric stats column wrapping in user sidebar #1593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cellio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for moving SQL out of the view and into the model.
|
Can we get a review from someone who's more code-fluent than I am? It's not large and it would be nice to either get this fixed or identify anything that still needs to be done here. Thanks! |
Closes #1590
I opted for a combination of using:
The above should be enough to address the issue and it also has an extra benefit of improving layout alignment across the sidebar:
The PR also comes with a bunch of other minor improvements (general view cleanup, several methods & helpers moving logic where it belongs - to models & helpers)