Skip to content

Conversation

@Oaphi
Copy link
Member

@Oaphi Oaphi commented Apr 1, 2025

Closes #1590

I opted for a combination of using:

  • fixed table layout;
  • disabled wrapping for the stats column (always the right one);
  • clipping the content of the stats column on overflow (with ellipsis);
  • showing a toolitp with the full value on hover;

The above should be enough to address the issue and it also has an extra benefit of improving layout alignment across the sidebar:

Screenshot from 2025-04-02 01-03-17

The PR also comes with a bunch of other minor improvements (general view cleanup, several methods & helpers moving logic where it belongs - to models & helpers)

@Oaphi Oaphi self-assigned this Apr 1, 2025
@Oaphi Oaphi changed the title removed accidental empty row from user stats table Fix numeric stats column wrapping in user sidebar Apr 1, 2025
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.28%. Comparing base (c1fed4f) to head (cbf0827).
Report is 8 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 59.24% <ø> (ø)
helpers 68.22% <100.00%> (+0.14%) ⬆️
jobs 28.00% <ø> (ø)
models 80.09% <100.00%> (+0.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Oaphi Oaphi marked this pull request as ready for review April 1, 2025 22:58
@Oaphi Oaphi requested review from a team, ArtOfCode-, cellio and trichoplax April 1, 2025 22:59
Copy link
Member

@cellio cellio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for moving SQL out of the view and into the model.

@cellio
Copy link
Member

cellio commented Apr 4, 2025

Can we get a review from someone who's more code-fluent than I am? It's not large and it would be nice to either get this fixed or identify anything that still needs to be done here. Thanks!

@ArtOfCode- ArtOfCode- merged commit 7122090 into develop Apr 4, 2025
9 checks passed
@ArtOfCode- ArtOfCode- deleted the 0valt/styling-fixes branch April 4, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visual bug: user profile stats tables are broken by overflow wrapping

4 participants