Skip to content

Conversation

@Oaphi
Copy link
Member

@Oaphi Oaphi commented Mar 7, 2025

Dependabot PR responsible for the issue: #1532

Relevant change happened in Nokogiri 1.8.0. Should fix #1551

@Oaphi Oaphi changed the title Dependency fixups Fix Nokogiri dependency issue due to bump to 1.8.3 Mar 7, 2025
@Oaphi Oaphi marked this pull request as ready for review March 7, 2025 06:23
@Oaphi Oaphi requested review from ArtOfCode- and cellio March 7, 2025 06:23
@Oaphi
Copy link
Member Author

Oaphi commented Mar 7, 2025

Would be great to have a confirmation from @cellio that a clean build of the uwsgi container after the change is applied succeeds before we merge (I do not anticipate issues, but it won't hurt to check):

docker compose down uwsgi
docker compose --progress=plain up --build --force-recreate --detach uwsgi > log/build.log

@cellio
Copy link
Member

cellio commented Mar 7, 2025

Would be great to have a confirmation from @cellio that a clean build of the uwsgi container after the change is applied succeeds before we merge (I do not anticipate issues, but it won't hurt to check):

Worked for me (on Mac ARM).

Copy link
Member

@cellio cellio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build.log
Tested and works for me. Don't know what the two mentions of mini_portal2 at different versions mean, but I assume you do. :-)

Looks like the rebuild was trying to recreate the db, which of course failed -- some exceptions/errors in the log, but the server came up and had the data I expected.

@cellio
Copy link
Member

cellio commented Mar 7, 2025

Discussed with @ArtOfCode- and he doesn't see any issues -- he deferred to us, @Oaphi, because we're the Docker users.

@cellio cellio merged commit d3de90f into develop Mar 7, 2025
9 checks passed
@cellio cellio deleted the 0valt/docker-fixes branch March 7, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker based installation fails: missing nokogiri gem

3 participants