Default filter user checks (issue #1082) #1120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taeir
reviewed
Jul 19, 2023
Contributor
Taeir
left a comment
There was a problem hiding this comment.
Thanks for fixing this issue :) I left a few questions and minor remarks. Please note that JavaScript is not the language I know the best so my apologies if those questions or remarks are not possible or required.
…JSDoc to make the intent clearer
…turning raw response if there is a pending request
Taeir
approved these changes
Jul 23, 2023
Contributor
Taeir
left a comment
There was a problem hiding this comment.
Looks good with the latest changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues raised in #1082, in particular — the problem with the client-side JavaScript attempting to fetch default filter for users that are not signed in. CircleCI (rubocop) is expected to fail until #1019 is merged in develop.
Regarding the addition of
_pendingUser- it exists to prevent additional calls to/users/meas I noticed there can be up to 5 made because theQPixel#usermethod doesn't account for other requests in flight. I could use abort signals, but this solution allows us not to send redundant requests in the first place.