-
Notifications
You must be signed in to change notification settings - Fork 400
Fix misc issues regarding user tests with graders #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1172 +/- ##
==========================================
- Coverage 63.63% 63.50% -0.14%
==========================================
Files 232 232
Lines 17044 17048 +4
==========================================
- Hits 10846 10826 -20
- Misses 6198 6222 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
andreyv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes!
The first change is related to TaskType.get_auto_managers(), which is supposed to return managers to be taken from the task. But you can see that currently there is no way for get_auto_managers() to account for a non-mandatory, arbitrarily named .h manager (even less so for additional .o managers). One could make it work now by returning None instead of [] from Batch.get_auto_managers(), but I don't think this is intended.
So I think that for now the proposed change is a sufficient short-term fix until a general solution is worked out.
The second change looks good. Managers are in general stored without .%l in the database, so it is fitting to do the same here.
|
Thanks for the review, @andreyv Made the requested changes. |
|
Thanks, merged. Also added tests in 81fb9df. |
This implementation re-uses the same header files as that for actual submissions. (Assumption: Task authors typically do not have different implementations for public and private header files.)
It seems that graders are not stored with the
.%lsuffix (Eg:grader.%l) but the original extension (Eg:grader.cpp) instead. Hence, this PR introduces an additional check for the original filename before declaring HTTP 404.This change is