Skip to content

Conversation

@wil93
Copy link
Member

@wil93 wil93 commented Mar 22, 2020

The cmsImportContest command fails when some participations specify multiple IPs separated by comma


This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #1147 into master will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
- Coverage   61.99%   61.95%   -0.05%     
==========================================
  Files         230      230              
  Lines       16604    16604              
==========================================
- Hits        10294    10287       -7     
- Misses       6310     6317       +7     
Flag Coverage Δ
#functionaltests 45.66% <0.00%> (+0.07%) ⬆️
#unittests 43.29% <0.00%> (ø)
Impacted Files Coverage Δ
cmscontrib/ImportContest.py 80.00% <0.00%> (ø)
cms/service/EvaluationService.py 65.95% <0.00%> (-1.60%) ⬇️
cms/service/ProxyService.py 57.44% <0.00%> (-1.60%) ⬇️
cms/server/contest/handlers/taskusertest.py 42.42% <0.00%> (-1.22%) ⬇️
cms/grading/scoring.py 75.58% <0.00%> (-1.17%) ⬇️
cms/server/admin/handlers/dataset.py 24.76% <0.00%> (-0.93%) ⬇️
cms/io/rpc.py 90.78% <0.00%> (-0.35%) ⬇️
cms/io/service.py 69.51% <0.00%> (ø)
cms/server/admin/handlers/base.py 67.79% <0.00%> (ø)
cms/grading/Job.py 89.57% <0.00%> (+0.47%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c9e92...5862703. Read the comment docs.

@andreyv andreyv merged commit 432d647 into cms-dev:master Feb 2, 2021
@andreyv
Copy link
Member

andreyv commented Feb 2, 2021

Thanks, looks good and works fine.

In the italy_yaml loader, the list syntax could be supported as well in the future:

    ip:
      - "192.168.0.0/24"
      - "10.0.0.0/8"

@wil93 wil93 deleted the fix_importcontest_subnet branch February 2, 2021 16:53
RezwanArefin01 pushed a commit to RezwanArefin01/cms that referenced this pull request Dec 27, 2021
The cmsImportContest command fails when some participations specify multiple IPs separated by comma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants