feat: Support skipping PK validation for columns #2310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernays
reviewed
Oct 31, 2025
| TypeSchema string `json:"type_schema,omitempty"` | ||
|
|
||
| // Some PK columns can be nullable if there are a part of a composite PK, so we want to skip validation for them. | ||
| SkipPKValidation bool `json:"skip_pk_validation"` |
Contributor
There was a problem hiding this comment.
Is it PK or PKC (primary key component)
bbernays
approved these changes
Oct 31, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
🤖 I have created a release *beep* *boop* --- ## [4.90.0](v4.89.1...v4.90.0) (2025-10-31) ### Features * Support skipping PK validation for columns ([#2310](#2310)) ([5ea21e3](5ea21e3)) ### Bug Fixes * **deps:** Update aws-sdk-go-v2 monorepo ([#2277](#2277)) ([ff1b11a](ff1b11a)) * **deps:** Update aws-sdk-go-v2 monorepo ([#2286](#2286)) ([f5de4f4](f5de4f4)) * **deps:** Update aws-sdk-go-v2 monorepo ([#2298](#2298)) ([c1edab7](c1edab7)) * **deps:** Update aws-sdk-go-v2 monorepo ([#2308](#2308)) ([bc9b670](bc9b670)) * **deps:** Update golang.org/x/exp digest to 8b4c13b ([#2271](#2271)) ([79eb8e1](79eb8e1)) * **deps:** Update golang.org/x/exp digest to df92998 ([#2291](#2291)) ([0708ef5](0708ef5)) * **deps:** Update Google Golang modules ([#2278](#2278)) ([3a714e8](3a714e8)) * **deps:** Update Google Golang modules ([#2285](#2285)) ([162e001](162e001)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.31.12 ([#2301](#2301)) ([3db0e41](3db0e41)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.14.2 ([#2275](#2275)) ([6be5fe6](6be5fe6)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.14.3 ([#2283](#2283)) ([1c7c102](1c7c102)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.14.4 ([#2284](#2284)) ([2c86149](2c86149)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.14.5 ([#2297](#2297)) ([b45ad80](b45ad80)) * **deps:** Update module github.com/cloudquery/codegen to v0.3.32 ([#2288](#2288)) ([7a64b2d](7a64b2d)) * **deps:** Update module github.com/spf13/cobra to v1.10.1 ([#2295](#2295)) ([9f9bb1b](9f9bb1b)) * **deps:** Update module github.com/stretchr/testify to v1.11.1 ([#2292](#2292)) ([767ae65](767ae65)) * **deps:** Update module golang.org/x/oauth2 to v0.31.0 ([#2296](#2296)) ([c07ee17](c07ee17)) * **deps:** Update module google.golang.org/grpc to v1.76.0 ([#2304](#2304)) ([7abe806](7abe806)) * **deps:** Update module google.golang.org/protobuf to v1.36.10 ([#2302](#2302)) ([21637c4](21637c4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
So we don't have to insert empty values instead of nulls as a workaround (see https://github.com/cloudquery/cloudquery-private/pull/9411)
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)