Repository navigation
chore: upgrade to @miniflare/tre@3.0.0-next.12 - #2810
Conversation
🦋 Changeset detectedLatest commit: ae3f4d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4285453795/npm-package-wrangler-2810You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2810/npm-package-wrangler-2810Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4285453795/npm-package-wrangler-2810 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4285453795/npm-package-cloudflare-pages-shared-2810Note that these links will no longer work once the GitHub Actions artifact expires. |
JacobMGEvans
left a comment
There was a problem hiding this comment.
Clever use of optional and nullish to create a reducer pattern.
Is the local -> miniflare2 a breaking change? Can that be notated in the changeset if it is.
I don't think so, |
d7aeb3f to
d4e3887
Compare
Codecov Report
@@ Coverage Diff @@
## main #2810 +/- ##
==========================================
- Coverage 73.99% 73.96% -0.04%
==========================================
Files 166 166
Lines 10191 10197 +6
Branches 2722 2728 +6
==========================================
+ Hits 7541 7542 +1
- Misses 2650 2655 +5
|
d4e3887 to
ae3f4d7
Compare
What this PR solves / how to test:
This PR upgrades
@miniflare/tre(Miniflare 3) to3.0.0-next.12, incorporating changes from3.0.0-next.11.Notably, this brings the following improvements to
wrangler dev --experimental-local:workerd/Miniflare 3 already supported Durable Objects, but Miniflare 3 didn't implement thedurableObjectsPersistoption required by Wrangler (🚀 Feature Request: Disable experimental DO persistance until Miniflare 3 supports this #2403, 🐛 BUG:wrangle dev --experimental-localdoesn't allow Durable Objects #2458)workerdrequires full URLs whenfetching with service bindings (🐛 BUG: Errors on d1 when using --experimental-local #2667)SIGINTinstead ofSIGTERMwhen terminatingworkerdforce closes HTTP connections, see Gracefully drain process on SIGTERM. workerd#244better-sqlite3@8: allows installation on Node 19 (🐛 BUG: Cannot install @miniflare/tre@3.0.0-next.7 #2318)Associated docs issues/PR:
N/A
Author has included the following, where applicable:
Tests(passing existing tests)Reviewer has performed the following, where applicable:
Fixes #2318
Fixes #2403
Fixes #2458
Fixes #2667