Skip to content

chore: upgrade to @miniflare/tre@3.0.0-next.12 - #2810

Merged
mrbbot merged 1 commit into
mainfrom
bcoll/miniflare-3.0.0-next.12
Feb 27, 2023
Merged

mrbbot merged 1 commit into
mainfrom
bcoll/miniflare-3.0.0-next.12

Conversation

@mrbbot

@mrbbot mrbbot commented Feb 27, 2023

Copy link
Copy Markdown
Contributor

What this PR solves / how to test:

This PR upgrades @miniflare/tre (Miniflare 3) to 3.0.0-next.12, incorporating changes from 3.0.0-next.11.

Notably, this brings the following improvements to wrangler dev --experimental-local:

Associated docs issues/PR:

N/A

Author has included the following, where applicable:

  • Tests (passing existing tests)
  • Changeset

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Fixes #2318
Fixes #2403
Fixes #2458
Fixes #2667

@mrbbot
mrbbot requested a review from a team as a code owner February 27, 2023 17:42
@changeset-bot

changeset-bot Bot commented Feb 27, 2023 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ae3f4d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Feb 27, 2023 •

Copy link
Copy Markdown
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4285453795/npm-package-wrangler-2810

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2810/npm-package-wrangler-2810

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4285453795/npm-package-wrangler-2810 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4285453795/npm-package-cloudflare-pages-shared-2810

Note that these links will no longer work once the GitHub Actions artifact expires.

@JacobMGEvans JacobMGEvans left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever use of optional and nullish to create a reducer pattern.

Is the local -> miniflare2 a breaking change? Can that be notated in the changeset if it is.

@mrbbot

mrbbot commented Feb 27, 2023

Copy link
Copy Markdown
Contributor Author

Is the local -> miniflare2 a breaking change?

I don't think so, applyD1BetaFacade is an internal function that we don't expose to users. 👍

@mrbbot
mrbbot force-pushed the bcoll/miniflare-3.0.0-next.12 branch from d7aeb3f to d4e3887 Compare February 27, 2023 17:56
@codecov

codecov Bot commented Feb 27, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #2810 (ae3f4d7) into main (700692f) will decrease coverage by 0.04%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2810      +/-   ##
==========================================
- Coverage   73.99%   73.96%   -0.04%     
==========================================
  Files         166      166              
  Lines       10191    10197       +6     
  Branches     2722     2728       +6     
==========================================
+ Hits         7541     7542       +1     
- Misses       2650     2655       +5     
Impacted Files Coverage Δ
packages/wrangler/src/dev/local.tsx 21.81% <0.00%> (-0.33%) ⬇️
packages/wrangler/src/dev/start-server.ts 65.60% <0.00%> (-0.43%) ⬇️
packages/wrangler/src/bundle.ts 93.89% <100.00%> (+0.02%) ⬆️

@mrbbot
mrbbot force-pushed the bcoll/miniflare-3.0.0-next.12 branch from d4e3887 to ae3f4d7 Compare February 27, 2023 18:09
@mrbbot
mrbbot merged commit 6278413 into main Feb 27, 2023
@mrbbot
mrbbot deleted the bcoll/miniflare-3.0.0-next.12 branch February 27, 2023 18:20
@github-actions github-actions Bot mentioned this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants