Skip to content

Remove unused Python workers flags and values - #8583

Merged
ryanking13 merged 1 commit into
mainfrom
gyeongjae/python-remove-unused-flags
Nov 18, 2026
Merged

ryanking13 merged 1 commit into
mainfrom
gyeongjae/python-remove-unused-flags

Conversation

@ryanking13

Copy link
Copy Markdown
Contributor

Removes a few obsolete Python workers related subcommands and flags

  • --pyodide-package-disk-cache-dir flag
  • make-pyodide-baseline-snapshot command

@ryanking13
ryanking13 requested review from a team as code owners November 18, 2026 05:15

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — A clean removal of unused Python workers flags and commands, with no correctness, security or performance concerns.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

🔒 Security: ✅ LGTM

This only removes obsolete flags and code. None of it affects security.


📖 AGENTS.md: ✅ LGTM

The AGENTS.md update correctly drops make-pyodide-baseline-snapshot from the description of the test command.


📋 Code Quality: ✅ LGTM

The dead code is removed consistently across the CLI, config, bridge, factory and test fixture.


⚡ Performance: ✅ LGTM

No performance impact.


📝 Documentation: ✅ LGTM

No documentation issues.


Reviewed commit: d07967c1

@ryanking13
ryanking13 enabled auto-merge November 18, 2026 05:46
@ryanking13
ryanking13 merged commit 8b933aa into main Nov 18, 2026
36 of 37 checks passed
@ryanking13
ryanking13 deleted the gyeongjae/python-remove-unused-flags branch November 18, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants