Repository navigation
Add the WPT navigator suite - #8531
Merged
Merged
Conversation
The navigator WPT files in html/webappapis/system-state-and-capabilities/ the-navigator-object test the navigator object that workers expose, but workerd did not run them. In this patch src/wpt gains a wpt_test for that directory. 11 of the 19 subtests pass. Five cases in navigator.any.js are marked as expected failures, each with the reason: navigator lacks the NavigatorID attributes appCodeName, appName, appVersion and product, and the userAgent value test needs XMLHttpRequest. Cases that need a Window are omitted.
Member
|
Doesn't feel like an amazing pass rate, but sure let's add it. |
npaun
approved these changes
Nov 17, 2026
There was a problem hiding this comment.
✅ Approved — This is a small addition of a WPT test config that follows the existing pattern, and I found no issues.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The new wpt_test target and its config follow the existing WPT test conventions. Each expected failure and each omission has a comment explaining why.
📝 Documentation: ✅ LGTM
No documentation issues.
Reviewed commit: 1e7fec13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The navigator WPT files in
html/webappapis/system-state-and-capabilities/the-navigator-objecttest thenavigatorobject that workers expose, but workerd did not run them.In this patch
src/wptgains awpt_testfor that directory. 11 of the 19 subtests pass. Five cases innavigator.any.jsare marked as expected failures, each with the reason:navigatorlacks the NavigatorID attributesappCodeName,appName,appVersionandproduct.userAgent valuetest needs XMLHttpRequest.The cases that need a Window (
clientInformation,registerProtocolHandler, and per-window identity) are omitted. Adding the missing attributes would be a runtime change, so it is left for a separate patch.