Skip to content

Add the WPT navigator suite - #8531

Merged
littledivy merged 1 commit into
mainfrom
littledivy/2026-11-17-wpt-navigator
Nov 17, 2026
Merged

littledivy merged 1 commit into
mainfrom
littledivy/2026-11-17-wpt-navigator

Conversation

@littledivy

Copy link
Copy Markdown
Member

The navigator WPT files in html/webappapis/system-state-and-capabilities/the-navigator-object test the navigator object that workers expose, but workerd did not run them.

In this patch src/wpt gains a wpt_test for that directory. 11 of the 19 subtests pass. Five cases in navigator.any.js are marked as expected failures, each with the reason:

  • navigator lacks the NavigatorID attributes appCodeName, appName, appVersion and product.
  • The userAgent value test needs XMLHttpRequest.

The cases that need a Window (clientInformation, registerProtocolHandler, and per-window identity) are omitted. Adding the missing attributes would be a runtime change, so it is left for a separate patch.

The navigator WPT files in html/webappapis/system-state-and-capabilities/
the-navigator-object test the navigator object that workers expose, but
workerd did not run them.

In this patch src/wpt gains a wpt_test for that directory. 11 of the 19
subtests pass. Five cases in navigator.any.js are marked as expected
failures, each with the reason: navigator lacks the NavigatorID
attributes appCodeName, appName, appVersion and product, and the
userAgent value test needs XMLHttpRequest. Cases that need a Window are
omitted.
@littledivy
littledivy requested review from a team as code owners November 17, 2026 07:32
@npaun

npaun commented Nov 17, 2026

Copy link
Copy Markdown
Member

Doesn't feel like an amazing pass rate, but sure let's add it.

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — This is a small addition of a WPT test config that follows the existing pattern, and I found no issues.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

The new wpt_test target and its config follow the existing WPT test conventions. Each expected failure and each omission has a comment explaining why.


📝 Documentation: ✅ LGTM

No documentation issues.


Reviewed commit: 1e7fec13

@littledivy
littledivy merged commit c86a4dc into main Nov 17, 2026
23 checks passed
@littledivy
littledivy deleted the littledivy/2026-11-17-wpt-navigator branch November 17, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants