Skip to content

Give the WebSocket kill-switch test the large test budget - #8492

Merged
floitsch merged 1 commit into
mainfrom
floitsch/websocket-killswitch-test-budget
Nov 16, 2026
Merged

floitsch merged 1 commit into
mainfrom
floitsch/websocket-killswitch-test-budget

Conversation

@floitsch

Copy link
Copy Markdown
Contributor

The WebSocket limit kill-switch test must verify that an actor can accept sockets past the 32,768-socket limit when the kill switch is enabled. It accepts 32,770 sockets in one actor, but currently inherits the medium test size. In downstream debug builds that allows only 15 seconds, so the test can time out before completing, as in the failed debug job.

Classify this test as large, matching the neighboring WebSocket limit test and giving it the downstream 60-second budget. The socket count, kill-switch configuration, and test variants remain unchanged, so the test still exercises acceptance beyond the limit.

The test accepts 32770 WebSockets in one actor to exercise the disabled
limit. Its downstream 15-second medium-test budget can expire in debug
builds before the test completes.

Use the large-test classification, matching the neighboring WebSocket
limit test. Preserve the socket count, kill-switch configuration, and
all generated variants.
@floitsch
floitsch requested review from a team as code owners November 16, 2026 12:31

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — A two-line test-size reclassification that matches the neighbouring WebSocket limit test. No findings.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

The change only gives the WebSocket kill-switch test a larger test size. No issues found.


Reviewed commit: d36a7058

@floitsch
floitsch enabled auto-merge (squash) November 16, 2026 13:01
@floitsch
floitsch merged commit 2b0a82c into main Nov 16, 2026
23 checks passed
@floitsch
floitsch deleted the floitsch/websocket-killswitch-test-budget branch November 16, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants