Repository navigation
Give the WebSocket kill-switch test the large test budget - #8492
Merged
Merged
Conversation
The test accepts 32770 WebSockets in one actor to exercise the disabled limit. Its downstream 15-second medium-test budget can expire in debug builds before the test completes. Use the large-test classification, matching the neighboring WebSocket limit test. Preserve the socket count, kill-switch configuration, and all generated variants.
There was a problem hiding this comment.
✅ Approved — A two-line test-size reclassification that matches the neighbouring WebSocket limit test. No findings.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The change only gives the WebSocket kill-switch test a larger test size. No issues found.
Reviewed commit: d36a7058
floitsch
enabled auto-merge (squash)
November 16, 2026 13:01
git-bruh
approved these changes
Nov 16, 2026
bartlomieju
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WebSocket limit kill-switch test must verify that an actor can accept sockets past the 32,768-socket limit when the kill switch is enabled. It accepts 32,770 sockets in one actor, but currently inherits the medium test size. In downstream debug builds that allows only 15 seconds, so the test can time out before completing, as in the failed debug job.
Classify this test as large, matching the neighboring WebSocket limit test and giving it the downstream 60-second budget. The socket count, kill-switch configuration, and test variants remain unchanged, so the test still exercises acceptance beyond the limit.