Skip to content

Split Python workers bazel configs - #8489

Merged
ryanking13 merged 1 commit into
mainfrom
gyeongjae/python-bazel-cleanup
Nov 19, 2026
Merged

ryanking13 merged 1 commit into
mainfrom
gyeongjae/python-bazel-cleanup

Conversation

@ryanking13

Copy link
Copy Markdown
Contributor

(No functional changes included)

Just a small bazel config cleanup for Python workers. Splits helpers.bzl to pyodide_extra.bzl (aligns with pyodide_extra.capnp) and pyodide_static.bzl based on its purpose.

  • pyodide_extra.bzl is used to generate Pyodide-related metadata into the workerd binary.
  • pyodide_static.bzl is used bundle JS/PY glue codes into the workerd binary.

@ryanking13
ryanking13 requested review from a team as code owners November 16, 2026 10:17

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of ab5ddff2.

This review, of ee613c5f

💬 Approved with comments — A clean split of the Bazel macros. The only note is an INFO that a public alias was removed without being mentioned in the description.

Findings: 1 info (1 is an inline comment on the diff)

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


📋 Code Quality: 💬 1 info

The split is a clean rename plus extraction. The only extra change is a removed public alias that nothing in the repository uses.

Recommendation: 💬 Optional Nits

  • [INFO] The public alias //src/pyodide:pyodide.capnp.bin@rule is removed, but the description says there are no functional changes. (src/pyodide/BUILD.bazel)
View full review
  • The rename of helpers.bzl to pyodide_extra.bzl and the extraction of pyodide_static.bzl are correct: the macro body is unchanged, the wd_ts_bundle load moved with it, and no references to helpers.bzl remain.
  • src/pyodide/BUILD.bazel deletes the public alias pyodide.capnp.bin@rule, which pointed to pyodide.capnp.bin@rule@<DEV_VERSION>.
    • Nothing in this repository uses that name: src/workerd/server/BUILD.bazel:441 defines its own local target with it.
    • The versioned targets used by src/pyodide/bundle/python_bundles.bzl and src/pyodide/scripts/upload_bundles.py are unaffected.
    • The removal is not mentioned in the description, which says there are no functional changes.

✅ All other checks passed

📝 Documentation: ✅ LGTM

The new module docstrings and the AGENTS.md rows match the new file layout.


Reviewed commit: ee613c5f

Comment thread src/pyodide/BUILD.bazel Resolved
@ryanking13
ryanking13 force-pushed the gyeongjae/python-bazel-cleanup branch from ee613c5 to ab5ddff Compare November 19, 2026 06:25

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 Approved with comments — A clean split of the Bazel macros. The only note is an INFO that a public alias was removed without being mentioned in the description.

Findings: 1 info

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


📋 Code Quality: 💬 1 info

The split is a clean rename plus extraction. The only extra change is a removed public alias that nothing in the repository uses.

Recommendation: 💬 Optional Nits

  • [INFO] The public alias //src/pyodide:pyodide.capnp.bin@rule is removed, but the description says there are no functional changes. (src/pyodide/BUILD.bazel)
View full review
  • The rename of helpers.bzl to pyodide_extra.bzl and the extraction of pyodide_static.bzl are correct: the macro body is unchanged, the wd_ts_bundle load moved with it, and no references to helpers.bzl remain.
  • src/pyodide/BUILD.bazel deletes the public alias pyodide.capnp.bin@rule, which pointed to pyodide.capnp.bin@rule@<DEV_VERSION>.
    • Nothing in this repository uses that name: src/workerd/server/BUILD.bazel:441 defines its own local target with it.
    • The versioned targets used by src/pyodide/bundle/python_bundles.bzl and src/pyodide/scripts/upload_bundles.py are unaffected.
    • The removal is not mentioned in the description, which says there are no functional changes.

✅ All other checks passed

📝 Documentation: ✅ LGTM

The new module docstrings and the AGENTS.md rows match the new file layout.


Reviewed commit: ab5ddff2 — same changes as ee613c5f, so this is that commit's review (no new review was run; line numbers are as of ee613c5f)

@ryanking13
ryanking13 enabled auto-merge November 19, 2026 09:37
@ryanking13
ryanking13 merged commit d939739 into main Nov 19, 2026
36 of 37 checks passed
@ryanking13
ryanking13 deleted the gyeongjae/python-bazel-cleanup branch November 19, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants