Repository navigation
Split Python workers bazel configs - #8489
Conversation
There was a problem hiding this comment.
Superseded by the review of
ab5ddff2.
This review, of ee613c5f
💬 Approved with comments — A clean split of the Bazel macros. The only note is an INFO that a public alias was removed without being mentioned in the description.
Findings: 1 info (1 is an inline comment on the diff)
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
📋 Code Quality: 💬 1 info
The split is a clean rename plus extraction. The only extra change is a removed public alias that nothing in the repository uses.
Recommendation: 💬 Optional Nits
- [INFO] The public alias
//src/pyodide:pyodide.capnp.bin@ruleis removed, but the description says there are no functional changes. (src/pyodide/BUILD.bazel)
View full review
- The rename of
helpers.bzltopyodide_extra.bzland the extraction ofpyodide_static.bzlare correct: the macro body is unchanged, thewd_ts_bundleload moved with it, and no references tohelpers.bzlremain. src/pyodide/BUILD.bazeldeletes the public aliaspyodide.capnp.bin@rule, which pointed topyodide.capnp.bin@rule@<DEV_VERSION>.- Nothing in this repository uses that name:
src/workerd/server/BUILD.bazel:441defines its own local target with it. - The versioned targets used by
src/pyodide/bundle/python_bundles.bzlandsrc/pyodide/scripts/upload_bundles.pyare unaffected. - The removal is not mentioned in the description, which says there are no functional changes.
- Nothing in this repository uses that name:
✅ All other checks passed
📝 Documentation: ✅ LGTM
The new module docstrings and the AGENTS.md rows match the new file layout.
Reviewed commit: ee613c5f
ee613c5 to
ab5ddff
Compare
There was a problem hiding this comment.
💬 Approved with comments — A clean split of the Bazel macros. The only note is an INFO that a public alias was removed without being mentioned in the description.
Findings: 1 info
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
📋 Code Quality: 💬 1 info
The split is a clean rename plus extraction. The only extra change is a removed public alias that nothing in the repository uses.
Recommendation: 💬 Optional Nits
- [INFO] The public alias
//src/pyodide:pyodide.capnp.bin@ruleis removed, but the description says there are no functional changes. (src/pyodide/BUILD.bazel)
View full review
- The rename of
helpers.bzltopyodide_extra.bzland the extraction ofpyodide_static.bzlare correct: the macro body is unchanged, thewd_ts_bundleload moved with it, and no references tohelpers.bzlremain. src/pyodide/BUILD.bazeldeletes the public aliaspyodide.capnp.bin@rule, which pointed topyodide.capnp.bin@rule@<DEV_VERSION>.- Nothing in this repository uses that name:
src/workerd/server/BUILD.bazel:441defines its own local target with it. - The versioned targets used by
src/pyodide/bundle/python_bundles.bzlandsrc/pyodide/scripts/upload_bundles.pyare unaffected. - The removal is not mentioned in the description, which says there are no functional changes.
- Nothing in this repository uses that name:
✅ All other checks passed
📝 Documentation: ✅ LGTM
The new module docstrings and the AGENTS.md rows match the new file layout.
Reviewed commit: ab5ddff2 — same changes as ee613c5f, so this is that commit's review (no new review was run; line numbers are as of ee613c5f)
(No functional changes included)
Just a small bazel config cleanup for Python workers. Splits
helpers.bzltopyodide_extra.bzl(aligns withpyodide_extra.capnp) andpyodide_static.bzlbased on its purpose.pyodide_extra.bzlis used to generate Pyodide-related metadata into the workerd binary.pyodide_static.bzlis used bundle JS/PY glue codes into the workerd binary.