Repository navigation
Allow the Wasm WPT suite to finish in downstream debug builds - #8404
Conversation
There was a problem hiding this comment.
Superseded by the review of
f9254577.
This review, of 398164bf
✅ Approved — A two-line test-size change in Bazel BUILD files. No issues found.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code reviewer: ✅ LGTM
Both changes only raise the test size to large. All cases stay enabled, and a hung suite still fails at the large-test deadline.
Reviewed commit: 398164bf
The full Wasm JavaScript API suite can exceed the 15-second medium-test timeout in downstream debug builds while still passing its subtests. Both variants timed out again on a build retry. Use the large test size for a 60-second downstream budget. Keep every subtest and assertion, along with the existing two-CPU allocation.
398164b to
f925457
Compare
There was a problem hiding this comment.
✅ Approved — A one-line test-size change in a Bazel BUILD file. No issues found.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code reviewer: ✅ LGTM
The change only raises the Wasm WPT test size to large. All subtests stay enabled.
Reviewed commit: f9254577
The Wasm JavaScript API WPT suite should exercise every subtest in downstream debug builds. It inherits the medium test size, which edgeworker maps to a 15-second timeout. The downstream debug retry killed both variants at that deadline while they were still passing subtests.
Classify the suite as large, giving downstream debug builds 60 seconds. Every WPT subtest and assertion remains enabled, along with the existing two-CPU allocation. A hung suite still fails at the standard large-test deadline.