Skip to content

Allow the Wasm WPT suite to finish in downstream debug builds - #8404

Merged
floitsch merged 1 commit into
mainfrom
floitsch/wasm-wpt-encoding-test-budgets
Nov 13, 2026
Merged

floitsch merged 1 commit into
mainfrom
floitsch/wasm-wpt-encoding-test-budgets

Conversation

@floitsch

@floitsch floitsch commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

The Wasm JavaScript API WPT suite should exercise every subtest in downstream debug builds. It inherits the medium test size, which edgeworker maps to a 15-second timeout. The downstream debug retry killed both variants at that deadline while they were still passing subtests.

Classify the suite as large, giving downstream debug builds 60 seconds. Every WPT subtest and assertion remains enabled, along with the existing two-CPU allocation. A hung suite still fails at the standard large-test deadline.

@floitsch
floitsch marked this pull request as ready for review November 12, 2026 22:08
@floitsch
floitsch requested review from a team as code owners November 12, 2026 22:08

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of f9254577.

This review, of 398164bf

✅ Approved — A two-line test-size change in Bazel BUILD files. No issues found.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code reviewer: ✅ LGTM

Both changes only raise the test size to large. All cases stay enabled, and a hung suite still fails at the large-test deadline.


Reviewed commit: 398164bf

The full Wasm JavaScript API suite can exceed the 15-second medium-test
timeout in downstream debug builds while still passing its subtests.
Both variants timed out again on a build retry.

Use the large test size for a 60-second downstream budget. Keep every
subtest and assertion, along with the existing two-CPU allocation.
@floitsch
floitsch force-pushed the floitsch/wasm-wpt-encoding-test-budgets branch from 398164b to f925457 Compare November 12, 2026 22:11
@floitsch floitsch changed the title Allow Wasm WPT and encoding smoke suites to finish in debug builds Allow the Wasm WPT suite to finish in downstream debug builds Nov 12, 2026

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — A one-line test-size change in a Bazel BUILD file. No issues found.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code reviewer: ✅ LGTM

The change only raises the Wasm WPT test size to large. All subtests stay enabled.


Reviewed commit: f9254577

@floitsch
floitsch merged commit b4e2a20 into main Nov 13, 2026
24 checks passed
@floitsch
floitsch deleted the floitsch/wasm-wpt-encoding-test-budgets branch November 13, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants