Repository navigation
Fix node:crypto diffieHellman with an imported public key - #8393
Merged
Merged
Conversation
`statelessDH` passed the keys to ncrypto's `DHPointer::stateless(ourKey, theirKey)` in the wrong order, so `diffieHellman()` threw for public keys imported from SPKI/JWK (X25519) and for all EC keys. In this patch the private key goes first, and `diffieHellman` is added to the `node:crypto` default export. Fixes #7743.
There was a problem hiding this comment.
✅ Approved — This is a small, correct fix to the argument order in statelessDH, with tests for the affected paths. No issues found.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
statelessDH now passes the private key and then the public key, which is the order DHPointer::stateless(ourKey, theirKey) expects. The new tests cover X25519 public keys imported from SPKI and JWK, and EC keys.
📝 Documentation: ✅ LGTM
No documentation issues.
Reviewed commit: b29f3756
jasnell
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
statelessDHpassed the keys to ncrypto'sDHPointer::stateless(ourKey, theirKey)in the wrong order, sodiffieHellman()threw for public keys imported from SPKI/JWK (X25519) and for all EC keys.In this patch the private key goes first, and
diffieHellmanis added to thenode:cryptodefault export. Fixes #7743.