Skip to content

dtor-throw-during-unwind fixes - #8170

Merged
mikea merged 1 commit into
mainfrom
maizatskyi/exceptions-dtor-throw-during-unwind
Nov 13, 2026
Merged

mikea merged 1 commit into
mainfrom
maizatskyi/exceptions-dtor-throw-during-unwind

Conversation

@mikea

@mikea mikea commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@mikea
mikea requested review from a team as code owners November 3, 2026 00:05

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of 90f05ab7.

This review, of aa47d1f5

✅ Approved — Small dependency bump plus lint-suppression adjustments with no behavioural change and no findings.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

The new suppressions in io-context.c++ and stored-value.c++ sit on KJ_REQUIRE_NONNULL calls inside continuation lambdas, and the code behaves as before. The suppression removed from actor-sqlite.c++ covered a noexcept deferred lambda, which crashes on failure rather than throwing. The dependency pin's commit, strip_prefix and URL are consistent.


Reviewed commit: aa47d1f5

@mikea
mikea force-pushed the maizatskyi/exceptions-dtor-throw-during-unwind branch from aa47d1f to 90f05ab Compare November 3, 2026 00:20

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of 6e613d9f.

This review, of 90f05ab7

✅ Approved — Small dependency bump plus lint-suppression adjustments with no behavioural change and no findings.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

The new suppressions in io-context.c++ and stored-value.c++ sit on KJ_REQUIRE_NONNULL calls inside continuation lambdas, and the code behaves as before. The suppression removed from actor-sqlite.c++ covered a noexcept deferred lambda, which crashes on failure rather than throwing. The dependency pin's commit, strip_prefix and URL are consistent.


Reviewed commit: 90f05ab7 — same changes as aa47d1f5, so this is that commit's review (no new review was run; line numbers are as of aa47d1f5)

@mikea
mikea force-pushed the maizatskyi/exceptions-dtor-throw-during-unwind branch from 90f05ab to 6e613d9 Compare November 12, 2026 23:14

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of ea89fb83.

This review, of 6e613d9f

✅ Approved — Dependency pin update and lint-suppression changes only, with no behavioural change and no findings.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

The capnp-cpp pin is consistent across commit, strip_prefix and URL. The NOLINT adjustments are lint-only and do not change behaviour.


Reviewed commit: 6e613d9f

@mikea
mikea force-pushed the maizatskyi/exceptions-dtor-throw-during-unwind branch from 6e613d9 to ea89fb8 Compare November 12, 2026 23:42
@mikea
mikea enabled auto-merge (rebase) November 12, 2026 23:42
@mikea
mikea disabled auto-merge November 12, 2026 23:43

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — The change is a dependency pin update plus lint-suppression adjustments only, with no behavioural change and no findings.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

The capnp-cpp pin is consistent across the commit, strip_prefix and URL. The NOLINT changes in actor-sqlite.c++, io-context.c++ and stored-value.c++ are lint-only. The suppressed KJ_REQUIRE_NONNULL calls sit inside promise continuations, not destructors.


Reviewed commit: ea89fb83

@mikea
mikea enabled auto-merge November 12, 2026 23:47
@mikea
mikea merged commit b78686c into main Nov 13, 2026
23 of 24 checks passed
@mikea
mikea deleted the maizatskyi/exceptions-dtor-throw-during-unwind branch November 13, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants