Repository navigation
dtor-throw-during-unwind fixes - #8170
Conversation
There was a problem hiding this comment.
Superseded by the review of
90f05ab7.
This review, of aa47d1f5
✅ Approved — Small dependency bump plus lint-suppression adjustments with no behavioural change and no findings.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The new suppressions in io-context.c++ and stored-value.c++ sit on KJ_REQUIRE_NONNULL calls inside continuation lambdas, and the code behaves as before. The suppression removed from actor-sqlite.c++ covered a noexcept deferred lambda, which crashes on failure rather than throwing. The dependency pin's commit, strip_prefix and URL are consistent.
Reviewed commit: aa47d1f5
aa47d1f to
90f05ab
Compare
There was a problem hiding this comment.
Superseded by the review of
6e613d9f.
This review, of 90f05ab7
✅ Approved — Small dependency bump plus lint-suppression adjustments with no behavioural change and no findings.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The new suppressions in io-context.c++ and stored-value.c++ sit on KJ_REQUIRE_NONNULL calls inside continuation lambdas, and the code behaves as before. The suppression removed from actor-sqlite.c++ covered a noexcept deferred lambda, which crashes on failure rather than throwing. The dependency pin's commit, strip_prefix and URL are consistent.
Reviewed commit: 90f05ab7 — same changes as aa47d1f5, so this is that commit's review (no new review was run; line numbers are as of aa47d1f5)
90f05ab to
6e613d9
Compare
There was a problem hiding this comment.
Superseded by the review of
ea89fb83.
This review, of 6e613d9f
✅ Approved — Dependency pin update and lint-suppression changes only, with no behavioural change and no findings.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The capnp-cpp pin is consistent across commit, strip_prefix and URL. The NOLINT adjustments are lint-only and do not change behaviour.
Reviewed commit: 6e613d9f
6e613d9 to
ea89fb8
Compare
There was a problem hiding this comment.
✅ Approved — The change is a dependency pin update plus lint-suppression adjustments only, with no behavioural change and no findings.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The capnp-cpp pin is consistent across the commit, strip_prefix and URL. The NOLINT changes in actor-sqlite.c++, io-context.c++ and stored-value.c++ are lint-only. The suppressed KJ_REQUIRE_NONNULL calls sit inside promise continuations, not destructors.
Reviewed commit: ea89fb83
capnproto/capnproto#2879