Skip to content

Conversation

@mancdaz
Copy link

@mancdaz mancdaz commented Dec 8, 2011

Not all image tarballs extract to kernel and image files that have the same basename as the tarball. Have changed the logic to figure out the name of the kernel and image files to import into glance rather than just assuming the basename.

…push into glance, don't assume the extracted kernel and image files will have the same basename as the tar.gz.
@smoser
Copy link
Contributor

smoser commented Dec 8, 2011

mancdaz, you and I did roughly the same thing here.
See my implementation at [1], primarily at [2].

I think it should cover your use case, and additionally supports ramdisks in the .tar.gz and also play .img and .img.gz files.

[1] #231
[2] smoser/devstack@9378e57

@mancdaz
Copy link
Author

mancdaz commented Dec 8, 2011

yes yours covers more! One thing I would say - in the image I was testing ( http://uec-images.ubuntu.com/oneiric/current/oneiric-server-cloudimg-amd64.tar.gz), both the vmlinuz-generic and vmlinuz-virtual kernels had been bundled. Your modifications stop on the first match of -vmlinuz*, which happens to be the generic one. Might be worth adding a check to make sure you're always getting -vmlinuz-virtual if it exists, and just -vmlinuz if not.

@vishvananda vishvananda closed this Dec 8, 2011
@vishvananda
Copy link
Contributor

merges are going through gerrit now guys.

@smoser
Copy link
Contributor

smoser commented Dec 9, 2011

i moved this to reviews.gerrit now.
@mancdaz, the fact that the -generic exists in that tarball is a bug, and it should be fixed now.
I opened at https://bugs.launchpad.net/ubuntu/+bug/901826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants