Skip to content

Conversation

@koenbittermann
Copy link

CSL Styles Pull Request Template

You're about to create a pull request to the CSL styles repository.
If you haven't done so already, see https://github.com/citation-style-language/styles/blob/master/CONTRIBUTING.md for instructions on how to contribute, and https://github.com/citation-style-language/styles/blob/master/STYLE_REQUIREMENTS.md for the requirements a style must meet before acceptance.
In addition, please fill out the pull request template below.

Description

This pull request adds a CSL style for the Journal of Cranio-Maxillofacial Surgery.

It follows the journal’s Guide for Authors:

  • Author–date citation system
  • Italicized author names in in-text citations
  • Two authors joined by “and”
  • More than two authors abbreviated with “et al.”
  • Chronological ordering of multiple in-text citations (oldest → newest)
  • Alphabetical bibliography with full author listing
  • Journal titles abbreviated according to Index Medicus (via container-title-short metadata)

Verified against the journal’s example references.

@github-actions
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@github-actions
Copy link

😟 There are some issues with your submission.

4 tests failed

journal-of-cranio-maxillofacial-surgery: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[13, "13:0: ERROR: Type dateTime doesn't allow value '2025-12-31'"], [13, "13:0: ERROR: Error valida...ERROR: Invalid sequence in interleave"], [6, "6:0: ERROR: Element info failed to validate content"]].empty?` to be truthy, got false

journal-of-cranio-maxillofacial-surgery: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/journal-of-cranio-maxillofacial-surgery"
     got: "https://www.zotero.org/styles/journal-of-cranio-maxillofacial-surgery"

(compared using ==)

journal-of-cranio-maxillofacial-surgery: must have a <rights> element

expected `#<CSL::Info children=[6]>.has_rights?` to be truthy, got false

journal-of-cranio-maxillofacial-surgery: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-min (100) to be greater than et-al-use-first (100)

Please check the test report for details.

@github-actions
Copy link

😟 There are some issues with your submission.

3 tests failed

journal-of-cranio-maxillofacial-surgery: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[20, "20:0: ERROR: Type dateTime doesn't allow value '2025-12-31'"], [20, "20:0: ERROR: Error valida...ERROR: Invalid sequence in interleave"], [6, "6:0: ERROR: Element info failed to validate content"]].empty?` to be truthy, got false

journal-of-cranio-maxillofacial-surgery: must have the correct Creative Commons BY-SA license text

expected: "This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License"
     got: "\n      This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License\n    "

(compared using ==)

Diff:
@@ -1,3 +1,5 @@
-This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License
+
+      This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License
+

journal-of-cranio-maxillofacial-surgery: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-min (100) to be greater than et-al-use-first (100)

Please check the test report for details.

@github-actions
Copy link

😟 There are some issues with your submission.

2 tests failed

journal-of-cranio-maxillofacial-surgery: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[20, "20:0: ERROR: Type dateTime doesn't allow value '2025-12-31'"], [20, "20:0: ERROR: Error valida...ERROR: Invalid sequence in interleave"], [6, "6:0: ERROR: Element info failed to validate content"]].empty?` to be truthy, got false

journal-of-cranio-maxillofacial-surgery: must have the correct Creative Commons BY-SA license text

expected: "This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License"
     got: "\n      This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 Unported License\n    "

(compared using ==)

Diff:
@@ -1,3 +1,5 @@
-This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License
+
+      This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 Unported License
+

Please check the test report for details.

@github-actions
Copy link

😟 There are some issues with your submission.

1 test failed

journal-of-cranio-maxillofacial-surgery: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[27, "27:0: ERROR: Did not expect element macro there"], [4, "4:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

Please check the test report for details.

Fix missing closing tags (schema validation
@github-actions
Copy link

😟 There are some issues with your submission.

1 test failed

journal-of-cranio-maxillofacial-surgery: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[14, "14:0: ERROR: Did not expect element macro there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

Please check the test report for details.

Remove UTF-8 BOM causing CSL schema misdetection
@github-actions
Copy link

😟 There are some issues with your submission.

1 test failed

journal-of-cranio-maxillofacial-surgery: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "Multiple errors encountered:\n1:36: FATAL: String not closed expecting \" or '\n1:36: FATAL: parsing XML declaration: '?>' expected"]].empty?` to be truthy, got false

Please check the test report for details.

@github-actions
Copy link

😟 There are some issues with your submission.

1 test failed

journal-of-cranio-maxillofacial-surgery: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "Multiple errors encountered:\n1:14: FATAL: expected '='\n1:14: FATAL: Malformed declaration exp...ting version\n1:14: FATAL: Blank needed here\n1:14: FATAL: parsing XML declaration: '?>' expected"]].empty?` to be truthy, got false

Please check the test report for details.

@POBrien333
Copy link
Contributor

Thank you for your submission.
The checklist that was there when you made the PR, was there for good reason ;)

Please add the template style you used and add the ISSN/eISSN to the style.

For the bibliography, pull out the author and title from the conditional as they repeat for each.
Also, try to use more groups with delimiters instead of all the affixes. Thanks

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 31, 2025
@github-actions
Copy link

😟 There are some issues with your submission.

1 test failed

journal-of-cranio-maxillofacial-surgery: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[14, "14:0: ERROR: Did not expect element macro there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

Please check the test report for details.

@github-actions
Copy link

😟 There are some issues with your submission.

1 test failed

journal-of-cranio-maxillofacial-surgery: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[14, "14:0: ERROR: Did not expect element macro there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

Please check the test report for details.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

journal-of-cranio-maxillofacial-surgery.csl (new)
(Bob Hancké, Martin Rhodes and Mark Thatcher, 20072012)
(Isabela Mares, 2001Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone and Tim Clark, 2019)


Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone and Tim Clark: A data citation roadmap for scholarly data repositories. Sci Data 6:28, 2019.
Bob Hancké, Martin Rhodes and Mark Thatcher: Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy. Oxford: Oxford University Press, 2007.
Isabela Mares: Firms and the welfare state: When, why, and how does social policy matter to employers? In: Peter A. Hall and David Soskice eds., Varieties of capitalism: The institutional foundations of comparative advantage. Oxford: Oxford University Press, 184–212, 2001.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants