feat(calculateBpc): calculate base peak chromatogram #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 95.45% 95.57% +0.11%
==========================================
Files 29 30 +1
Lines 484 497 +13
Branches 103 106 +3
==========================================
+ Hits 462 475 +13
Misses 20 20
Partials 2 2
Continue to review full report at Codecov.
|
targos
reviewed
Jun 23, 2017
src/ms/calculateBpc.js
Outdated
| var massSpectra = ms.data; | ||
| var bpc = []; | ||
| for (var massSpectrum of massSpectra) { | ||
| bpc.push(Math.max(...massSpectrum[1])); |
There was a problem hiding this comment.
this is very inefficient. use https://www.npmjs.com/package/ml-array-max
maasencioh
added a commit
that referenced
this pull request
Jun 26, 2017
* feat(calculateBpc): calculate base peak chromatogram * chore(calculateBpc): use ml-array-max for performance
maasencioh
added a commit
that referenced
this pull request
Jun 26, 2017
* feat: initial baseline implementation * feat: initial baseline implementation * Add test case * Release v2.0.7 * Upgrade dependencies * feat(calculateBpc): calculate base peak chromatogram (#31) * feat(calculateBpc): calculate base peak chromatogram * chore(calculateBpc): use ml-array-max for performance * chore(integrate1D): add baseline correction * test: fix merge conflicts * test: remove async tags
maasencioh
added a commit
that referenced
this pull request
Jun 26, 2017
* feat: initial baseline implementation * feat: initial baseline implementation * Add test case * Release v2.0.7 * Upgrade dependencies * feat(calculateBpc): calculate base peak chromatogram (#31) * feat(calculateBpc): calculate base peak chromatogram * chore(calculateBpc): use ml-array-max for performance * chore(integrate1D): add baseline correction * test: fix merge conflicts * test: remove async tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.