fix: move noisy peer log lines to Debug level#2782
Open
rootulp wants to merge 1 commit intocelestiaorg:mainfrom
Open
fix: move noisy peer log lines to Debug level#2782rootulp wants to merge 1 commit intocelestiaorg:mainfrom
rootulp wants to merge 1 commit intocelestiaorg:mainfrom
Conversation
Peer connection, reconnection, and rejection messages dominate logs at Info level on consensus nodes, obscuring important events. Downgrade these routine operational messages to Debug in p2p/switch.go and p2p/pex/pex_reactor.go. Closes celestiaorg#2781 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rach-id
approved these changes
Feb 8, 2026
Member
rach-id
left a comment
There was a problem hiding this comment.
what the reason behind this change? is it to make it easier for validators to read logs?
| numToDial = r.Switch.MaxNumOutboundPeers() - (out + dial) | ||
| ) | ||
| r.Logger.Info( | ||
| r.Logger.Debug( |
Member
There was a problem hiding this comment.
I think this should remain info because it gives you an update on the number of peers you have. Otherwise, you need to read a whole lot of debug logs or check the RPC
| updatedAddrBook := r.book.GetSelection() | ||
| if len(updatedAddrBook) == 0 { | ||
| r.Logger.Info("No addresses to dial. Falling back to seeds") | ||
| r.Logger.Debug("No addresses to dial. Falling back to seeds") |
Member
There was a problem hiding this comment.
same, this one shows you early if the persistent peers or your address book are not working as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
p2p/switch.gofrom Info/Error to Debugp2p/pex/pex_reactor.gofrom Info to Debuglog_level = "info"Closes #2781
Test plan
go build ./...compiles successfullygo test ./p2p/pex/... -count=1passeslog_level = "debug"🤖 Generated with Claude Code