Always install dxtbx without touching conda_base - redux #511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR #474 went through a few variants - but was reverted in 2010053 due to issues in other downstream packages - see #473 (comment).
The problem; #473 - cctbx wants to be able to use a bootstrap-flavor dxtbx, but without writing to
conda_base/, because it may be readonly or would otherwise prefer that it is not written to. The original intent of #474 was to fix this, and went through persistence of environment variable, to inverting the default, to just attempting to never write to conda_base in the first place.This PR reintroduces the changes, with extra care to be taken to ensure that nothing in e.g. dials or xia2 is broken.
I believe that 0c0eeb2 actually fixes this - the dxtbx dispatchers are regenerated directly after configuration, where they are normally generated before configuration in the standard libtbx configuration process. The problem is that subsequent
libtbx.refreshruns were apparently starting from scratch and not picking up the configuration change fromlibtbx.env.