Skip to content

Remove Google Fonts Dependency#57

Merged
tmilewski merged 1 commit intomasterfrom
remove-google-font
Feb 26, 2014
Merged

Remove Google Fonts Dependency#57
tmilewski merged 1 commit intomasterfrom
remove-google-font

Conversation

@tmilewski
Copy link
Copy Markdown
Contributor

No description provided.

@jescalan
Copy link
Copy Markdown

I kind of like having lato in there for the design aspect 😀

@senadir
Copy link
Copy Markdown

senadir commented Feb 17, 2014

can i use a custom font of mine and delete the other,
also, i have Font Awesome in the page, how could i use it instead of entypo font, so i dont have to load two icon fonts

@jescalan
Copy link
Copy Markdown

@assassinateur if you want to replace the font and icons, at this point it might be a good idea to fork this project. we try to make it as flexible as we can, but being able to swap out the icon set and fonts is a little beyond scope

@tmilewski
Copy link
Copy Markdown
Contributor Author

@Jenius While I do like the font and, I'll be the first to admit, it is rather light, I do see a fundamental issue with its presence in the library. I don't believe that it aligns with the goals of the project.

On top of that, it's another two requests on every page load for a rather small style difference. IMHO.

Using Google Fonts:
before

Using System Fonts:
after

@jescalan
Copy link
Copy Markdown

I understand the concern and desire to eliminate, but tbh the google fonts version looks vastly better still in my eyes. Like huge amounts. Maybe we could make it optional?

@jgclifton
Copy link
Copy Markdown

Definitely think this should be moved in to an option - this could potentially cause problems for https sites as it's using just the http protocol. With Google webfonts you can just use //fonts.googleapis.com/css?family=Lato:900 and it will use the appropriate protocol if you do want to keep this in the library.

@jescalan
Copy link
Copy Markdown

The https thing isn't an issue, if you look at the code above protocol is an option

@jgclifton
Copy link
Copy Markdown

Sorry, which code are you referring to?

@jescalan
Copy link
Copy Markdown

@jgclifton
Copy link
Copy Markdown

ah I see now! I'm intrigued - what's the advantage of doing it that way vs just using //fonts... and having the appropriate protocol automatically served?

@tmilewski
Copy link
Copy Markdown
Contributor Author

@jgclifton The main issue is local testing and development. In local development, // maps to file://.

@jgclifton
Copy link
Copy Markdown

@tmilewski thanks 👍

@jescalan
Copy link
Copy Markdown

I would be totally ok with this if the default were set to true 😀

tmilewski pushed a commit that referenced this pull request Feb 26, 2014
Remove Google Fonts Dependency
@tmilewski tmilewski merged commit 7b11a3e into master Feb 26, 2014
@tmilewski tmilewski deleted the remove-google-font branch February 26, 2014 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants