-
Notifications
You must be signed in to change notification settings - Fork 256
feat(WD-31917): enterprise store #15904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15904 +/- ##
=======================================
Coverage 47.53% 47.53%
=======================================
Files 37 37
Lines 5749 5749
=======================================
Hits 2733 2733
Misses 3016 3016 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
Thanks @andesol! I'll add comments for Mattea too as she's off
I'm also waiting to hear back from the PM re where she wants the item to be in the meganav. Will update when I hear back - thank you! |
99a685f to
86bbec8
Compare
|
@eliman11 Thanks for the review! I implemented the changes. I didn't know there was a newletter pattern. Based on the PM's comment on the navigation doc I added the enterprise store to the meganav under Please have a look. |
Done
New page: /enterprise-store
TODO
QA
Issue / Card
https://warthogs.atlassian.net/browse/WD-31917
Comments
This part (rule and button text) is slightly different than in the design, but I decided to reuse from other pages. If updated, might be better to update it everywhere.