Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write CLI errors to stderr #2317

Merged
merged 8 commits into from
Nov 18, 2024
Merged

Write CLI errors to stderr #2317

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3b65e72
Use STDERR for errors (if available)
jhatlak Oct 16, 2024
709482b
Fix ListAliasesTest
jhatlak Oct 16, 2024
245cf62
Turn missing aliases into warning
jhatlak Oct 21, 2024
90ca13d
Fix ListAliasesTest
jhatlak Oct 21, 2024
3e92fca
Improve Migrate command coverage
jhatlak Oct 21, 2024
5fa707c
Let PHPCS search PHPDoc annotations for uses
jhatlak Oct 21, 2024
7f236ad
Fix undefined array key access
jhatlak Oct 21, 2024
c9de063
Restore if/else/return flow
jhatlak Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Let PHPCS search PHPDoc annotations for uses
  • Loading branch information
@jhatlak
jhatlak committed Oct 21, 2024
commit 5fa707ca55cf7dcb5acff69c6310894d4d5519a4
6 changes: 6 additions & 0 deletions phpcs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@

<rule ref="CakePHP"/>

<rule ref="SlevomatCodingStandard.Namespaces.UnusedUses">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests do not contain all necessary imports (uses) right now because without this PHPCS will complain.
I added the missing imports to MigrateTest and will leave the rest for someone else to clean up.

<properties>
<property name="searchAnnotations" value="true"/>
</properties>
</rule>

<arg value="nps"/>

<file>src/</file>
Expand Down