Allow skipping redirects for extensions. #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Jun 29, 2025
tests/TestCase/Middleware/UnauthorizedHandler/RedirectHandlerTest.php
Outdated
Show resolved
Hide resolved
tests/TestCase/Middleware/UnauthorizedHandler/RedirectHandlerTest.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Mark Story <[email protected]>
…est.php Co-authored-by: Mark Story <[email protected]>
…est.php Co-authored-by: Mark Story <[email protected]>
markstory
reviewed
Jul 1, 2025
- We can use one of the existing exceptions from the plugin. - Expand test coverage to cover all the new branches
markstory
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves cakephp/authentication#717
This happens when you have default (admin) routing and just add extensions into it in general.
You cannot then control for what actions only.
And if you then get redirects on those, that is weird (API etc) and creates overhead on the server.