Exception message #430
Merged
Exception message #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since UnauthenticatedException now extends HttpException this is the message that gets shown to end user which is not desirable.
markstory
reviewed
Jan 4, 2021
| throw new UnauthenticatedException( | ||
| 'No identity found. You can skip this check by configuring `requireIdentity` to be `false`.' | ||
| ); | ||
| throw new UnauthenticatedException($this->getConfig('unauthenticatedMessage', '')); |
Member
There was a problem hiding this comment.
Should we have a default message? Something like 'Authentication is required'?
Member
Author
There was a problem hiding this comment.
The constructor already sets one:
authentication/src/Authenticator/UnauthenticatedException.php
Lines 40 to 42 in 048648d
Member
|
Should we allow the exception message to be empty instead of forcing the default in the constructor? |
Member
|
I don't think an empty message is useful behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dev centric error message. Since
UnauthenticatedExceptionnow extendsHttpExceptionthis is the message that gets shown to end user which is not desirable. Also made the error message configurable.