Skip to content

Refactor 2DLRMP unit into generalized 2D column unit #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbreue16 merged 7 commits into from
Aug 4, 2025
Merged

Refactor 2DLRMP unit into generalized 2D column unit #458

jbreue16 merged 7 commits into from
Aug 4, 2025

Conversation

@jbreue16
Copy link
Contributor

@jbreue16 jbreue16 commented Jul 16, 2025 •
edited
Loading

todo

  • incorporate homogeneous particles into unit
  • use generalized interface, add general rate particles
  • adapt initialization, jacobian and solve functions
  • implement tests
    • LRMP2D tests
      • adjust the tests that were already implemented
      • add comparison to 2DGRM with $D^p->\infty$
    • GRM2D tests
      • test we have for LRMP
      • reference tests, numerical and analytical
    • mixed particle model test
    • 1D == 2D without radial variance SMA LWE test
  • Improve recomputation of Jacobian

@jbreue16 jbreue16 self-assigned this Jul 16, 2025
This was referenced Jul 16, 2025
Merged
Merged
@jbreue16
Copy link
Contributor Author

jbreue16 commented Jul 16, 2025

Adapt keepParticleSingletonDim Exporter/API to particle modularization for your notice @schmoelder

@jbreue16 jbreue16 changed the base branch from master to jb/dev July 22, 2025 12:46
@jbreue16 jbreue16 force-pushed the feature/dg2d branch 9 times, most recently from 9d690d1 to bc045a8 Compare July 29, 2025 12:20
@jbreue16 jbreue16 force-pushed the feature/dg2d branch 3 times, most recently from 0981c42 to 9bca88d Compare August 4, 2025 09:06
jbreue16 added 6 commits August 4, 2025 11:23
@jbreue16
Standardize function names across particle and bulk transport operator
07ce9a2
@jbreue16
Add 2DFV GRM numerical and analytical reference tests
8ea1933
@jbreue16
Adapt keepParticleSingletonDim Exporter/API to particle modularization
29b3ae2
@jbreue16
Update 1D column unit
3890ff4 
Always recompute Jacobian in 1D unit if wantJac

Fix linear solve of inlet Jacobian block in 1D column unit

Add compression to AD Jacobian

Implement function to check analytic Jacobian against AD during
simulation

Add exception for NPARTYPE = 0 but particle group exists
@jbreue16
Move NNZ, binding, film diffusion Jacobian pattern from particle base…
eb6eb8f 
… class to derived class
@jbreue16
Fix return data handling for units without particles
8bd28c4
@jbreue16 jbreue16 merged commit 348ef14 into jb/dev Aug 4, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in CADET Repositories Aug 4, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jbreue16 jbreue16

Labels

enhancement feature request numerics unit operation model

Projects

CADET Repositories
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jbreue16