Add check for correct size of field NBOUND in CSTR#447
Merged
Conversation
Contributor
Author
|
@schmoelder do you have any objections? maybe some configurations will fail due to this, but i think its a bug |
Contributor
Absolutely not, good catch! 🤓 Note, there are some other instances where parameter checks could be improved to avoid issues, see #28 |
schmoelder
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a check for correct size of field NBOUND in CSTR, which is implemented in all the other units.
Not checking this can lead to undefined behaviour even when adsorption is correctly specified.