Add competitive inhibition and uncompetitive inhibition#397
Add competitive inhibition and uncompetitive inhibition#397AntoniaBerger merged 1 commit intomasterfrom
Conversation
1f568e7 to
2c83c64
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR aims to update and refactor Michaelis–Menten test cases in reaction model simulations to reflect new distinctions between substrates and inhibitors. Key changes include:
- Renaming test cases from inhibitor-related to substrate/non-inhibitor nomenclature.
- Adding an extra tag "[testHere]" to test case identifiers.
- Removing the inhibition-specific test function from ReactionModelTests.cpp.
Reviewed Changes
Copilot reviewed 7 out of 14 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/ReactionModels.cpp | Test case names updated to reflect substrates/non-inhibitor behavior and extra tags added. |
| test/ReactionModelTests.cpp | Inhibition-specific test function removed to align with new test case focus. |
Files not reviewed (7)
- doc/interface/reaction/michaelis_menten_kinetics.rst: Language not supported
- doc/interface/reaction/michaelis_menten_kinetics_with_inhibition.rst: Language not supported
- doc/modelling/reaction/michaelis_menten_kinetics.rst: Language not supported
- test/data/configuration_CSTR_MichaelisMenten_benchmark1.json: Language not supported
- test/data/configuration_CSTR_MichaelisMenten_benchmark2.json: Language not supported
- test/data/configuration_CSTR_MichaelisMenten_twoInhib_benchmark1.json: Language not supported
- test/data/configuration_CSTR_MicroKineticsSMA_benchmark1.json: Language not supported
Comments suppressed due to low confidence (2)
test/ReactionModelTests.cpp:322
- The removal of the inhibition-specific test function could reduce test coverage for inhibition behavior. Ensure that inhibition scenarios are adequately covered by the new tests or update the documentation accordingly.
// Removed testMichaelisMentenToSMAInhibitionMicroKinetic function
test/ReactionModels.cpp:92
- Test case names now reference 'substrates' rather than 'inhibitors', which seems inconsistent with the PR title mentioning inhibition. Verify that the test descriptions, configuration files, and overall PR purpose are aligned.
TEST_CASE("MichaelisMenten kinetic with two substrates and specific mass action law micro-kinetics yield same result", "[MichaelisMenten],[ReactionModel],[Simulation],[Reference],[CI],[testHere]")
c759040 to
d199d61
Compare
a29d278 to
2323277
Compare
doc/interface/reaction/michaelis_menten_kinetics_with_inhibition.rst
Outdated
Show resolved
Hide resolved
doc/interface/reaction/michaelis_menten_kinetics_with_inhibition.rst
Outdated
Show resolved
Hide resolved
schmoelder
left a comment
There was a problem hiding this comment.
Excellent work @AntoniaBerger, really looking forward to this feature in CADET :)
Just some small comments, mostly regarding typos.
|
In general, rates are defined per unit volume and time, whereas fluxes are defined per unit area and time. However, the terminology can be confusing, as the term flux is sometimes used interchangeably with rate, for instance, in metabolic flux analysis. For clarity and consistency with SI units, let's use the term rate here. |
eaebbad to
a2412b8
Compare
2f80a85 to
3c2f5ac
Compare
|
what does the commit "Enable backward compatibility with previous Michaelis Menten interface" do exactly? |
It deletes the old version, which had an additional module for the competitive version, and integrates these features into the standard Meachelis Menten implementation. However, doing so also makes it possible to use the Edit: This is already the squashes version of this branch, so the commits are not 100% clean anymore. |
ok i understand this as no multiple interfaces, which is great |
695e1c2 to
7a7b8eb
Compare
7a7b8eb to
37b3e70
Compare
Extent of the Michaelis-Menten module The Michaelis-Menten reaction module can simulate multiple substrates. three different inhibition models (competitive, uncompetitive and non-competitive inhibition). Main changes: - Michaelis–Menten - Benchmark tests - documentation. Docu (to be checked)
37b3e70 to
6c18776
Compare
jbreue16
left a comment
There was a problem hiding this comment.
looks good, so cool !
we should remove the USER_SOLUTION_TIMES from the config files in the future to not have multiple thousands lines of code just for this, I thought that before in my PR's, Ive opened an issue for this
I believe all requested changes were addressed.
This PR fixes #386 and fixes #388.
To-do