Add linearization to Mobile Phase Modulator Langmuir Binding#261
Merged
Add linearization to Mobile Phase Modulator Langmuir Binding#261
Conversation
…lize against c0 < 0.
jbreue16
requested changes
Aug 6, 2024
Contributor
jbreue16
left a comment
There was a problem hiding this comment.
Looks good to me, but I think we should add a separate test case for the linearization
src/libcadet/model/binding/MobilePhaseModulatorLangmuirBinding.cpp
Outdated
Show resolved
Hide resolved
jbreue16
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stabilizes the Mobile Phase Modulator Langmuir Binding for$c_{p,0} <= 0$ .
The isotherm equation:
can be undefined for$c_{p,0} <= 0$ for two reasons:
Therefore a Taylor series linearization with respect to$c_{p,0}$ has been introduced around $c_{p,0} <= \epsilon$ where $\epsilon$ is a small number.
The CADET-core tests failed with the old formulation for$c_{p,0} <= 0$ and now pass. A full simulation where $c_{p,0}$ dips below zero due to oscillations has been performed to confirm that the linarization works.
Once this is merged we can merge fau-advanced-separations/CADET-Process#163.