Fix building with clang 15 on OSX #609

[wabscale]

The problem is explained in the issue, but to reiterate:

Newer versions of apple's clang will error if there is an undefined reference to TARGET_OS_*. The solution to this is to include the TargetConditionals.h file ahead of any references. The problem originates here:

javacpp/src/main/java/org/bytedeco/javacpp/tools/Generator.java

Lines 313 to 318 in f77f8d7

	out.println("#ifdef __ANDROID__");
	out.println(" #include <android/log.h>");
	out.println("#elif defined(__APPLE__) && defined(__OBJC__)");
	out.println(" #include <TargetConditionals.h>");
	out.println(" #include <Foundation/Foundation.h>");
	out.println("#endif");

The TargetConditionals.h is only included if both __APPLE__ and __OBJC__ are definied. If you use a brew installed llvm (currently version 15), the __APPLE__ will be defined but __OBJC__ is not.

What I have done is made it so that TargetConditionals.h is always included on apple, and the Foundation/Foundation.h is only included when __OBJC__ is defined. The result is this:

#ifdef __ANDROID__
    #include <android/log.h>
#elif defined(__APPLE__)
    #include <TargetConditionals.h>
#endif

#if defined(__OBJC__) 
    #include <Foundation/Foundation.h>
#endif

I've tested this on OSX 12.6, clang 15 (installed via brew install llvm).

[saudet]

Thanks for the fix! To make sure we don't break anything, we probably want more something like this though:

--- a/src/main/java/org/bytedeco/javacpp/tools/Generator.java
+++ b/src/main/java/org/bytedeco/javacpp/tools/Generator.java
@@ -315,6 +315,8 @@ public class Generator {
         out.println("#elif defined(__APPLE__) && defined(__OBJC__)");
         out.println("    #include <TargetConditionals.h>");
         out.println("    #include <Foundation/Foundation.h>");
+        out.println("#elif defined(__APPLE__)");
+        out.println("    #include <TargetConditionals.h>");
         out.println("#endif");
         out.println();
         out.println("#ifdef __linux__");

[wabscale]

Great, I've overwritten the commit with what you have requested.