You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Replay iframe guard: blocked, unblocked then navigated iframe still produces a false violation (#124 case 2) #147
Follow-up of #124 (case 1 fixed in #138). Case 2: an iframe that is blocked, then unblocked and navigated is still never reopened by the guard; it drops the attach and reports one false violation until the next full snapshot, which can hide a later real one.
Why the guard cannot fix it alone: the bugsee/rrweb fork drops the change that blocks an iframe and every attribute change while iframe is in blockSelector (the default), emitting only the rr_width/rr_height marker, so the guard cannot see the unblock nor tell an iframe's own block from an ancestor's. Needs an 'unblocked' signal from the bugsee/rrweb fork, then the guard can reopen on it. See the LIMIT note in packages/replay/src/iframe-guard.ts.
Verified against current main (c7f7f12): not stale, but not fixable in this repo alone. The LIMIT note in packages/replay/src/iframe-guard.ts still describes the behaviour. The guard only sees rrweb events, and the fork emits no signal when a blocked iframe is unblocked. The recorder is a prebuilt bundle (vendor/rrweb-record, built from bugsee/rrweb branch bugsee-port-2.2.2), so the signal has to be added there and the bundle rebuilt and re-pinned (sha256 in packages/rrweb/src/index.test.ts). A guard-only workaround (evaluating block rules on the live iframe through the rrweb mirror) would restate the recorder's block logic and weaken the fail-closed design, so I have not done it without an owner decision. No PR opened; waiting on direction.
Activity
fix(replay): iframe guard no longer reports the nested-marker false v…
krassx commentedon Nov 12, 2026
Verified against current main (c7f7f12): not stale, but not fixable in this repo alone. The LIMIT note in packages/replay/src/iframe-guard.ts still describes the behaviour. The guard only sees rrweb events, and the fork emits no signal when a blocked iframe is unblocked. The recorder is a prebuilt bundle (vendor/rrweb-record, built from bugsee/rrweb branch bugsee-port-2.2.2), so the signal has to be added there and the bundle rebuilt and re-pinned (sha256 in packages/rrweb/src/index.test.ts). A guard-only workaround (evaluating block rules on the live iframe through the rrweb mirror) would restate the recorder's block logic and weaken the fail-closed design, so I have not done it without an owner decision. No PR opened; waiting on direction.