Skip to content

Conversation

@fbuchlak
Copy link

@fbuchlak fbuchlak commented Jun 29, 2023

Based on discussions 1560, 1580 and pull request #4

New cdk projects created with cdk init provides set of feature flags. Specifically @aws-cdk/aws-lambda:recognizeVersionProps which changes order of lambda layers (see Function.renderLayers).

This pull request changes ids of created layers (based on their priorities described in corresponding constructs) and allows to create test templates with AppProps.

There might be a problem if you want to add additional layers to bref construct along with mentioned flag.
To resolve such problems, you may need to "name" additional layers correctly (so they are sorted as you wish in previously mentioned renderLayers method).

@mnapoli
Copy link
Member

mnapoli commented Jun 29, 2023

Woww this is crazy 🤯 I don't understand why they did that, but thank you for figuring this out!

@mnapoli mnapoli merged commit ab01888 into brefphp:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants