Skip to content

refactor(cli): refactor run command, consolidate terminal and io logic into shared streamer #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shayne-snap wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(cli): refactor run command, consolidate terminal and io logic into shared streamer #182

shayne-snap wants to merge 1 commit into from

Conversation

@shayne-snap
Copy link
Contributor

@shayne-snap shayne-snap commented Jan 30, 2026 •
edited
Loading

Info

issue: #35

This is the first part of the exec command. After this PR, I'll submit a PR resuse terminal streamer to implement exec command.

Key Changes

  • Consolidates terminal raw mode and IO streaming into a shared StreamManager component.
  • Fixes a terminal restoration bug by ensuring RawModeGuard is dropped before process exit.
  • Improves IO reliability by ensuring all output is flushed before the CLI exits.
  • Enhances macOS build reliability by using ditto for runtime copying.
  • Centralizes management flags (name, rm, detach) for consistency across commands.
  • Moves tokio runtime initialization to a safe block to avoid environment variable race conditions.

Testing

  • make test:cli
  • manually test ./target/debug/run

@shayne-snap
refactor(cli): consolidate terminal and io logic into shared streamer
0872c1a 
This refactoring:
- Consolidates terminal raw mode and IO streaming into a shared StreamManager component.
- Fixes a terminal restoration bug by ensuring RawModeGuard is dropped before process exit.
- Improves IO reliability by ensuring all output is flushed before the CLI exits.
- Enhances macOS build reliability by using ditto for runtime copying.
- Centralizes management flags (name, rm, detach) for consistency across commands.
- Moves tokio runtime initialization to a safe block to avoid environment variable race conditions.
@shayne-snap shayne-snap force-pushed the refactor/cli-terminal-shared branch from 253cb5a to 0872c1a Compare January 30, 2026 03:13
@shayne-snap shayne-snap marked this pull request as ready for review January 30, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shayne-snap