Repository navigation
Allow setting custom headers on API connection - #562
Merged
Merged
Conversation
|
Verified that @mattwiller has signed the CLA. Thanks for the pull request! |
iamharish
approved these changes
Mar 20, 2018
| * This undoes any previous calls to asUser(). | ||
| * @see #asUser | ||
| */ | ||
| public void asSelf() { |
| this.addHeader(header, customHeaders.get(header)); | ||
| } | ||
| } | ||
| this.headers.add(new RequestHeader("X-Box-UA", api.getBoxUAHeader())); |
Contributor
There was a problem hiding this comment.
Minor - this can probably go as a header in the api connection as well instead of lingering around as a special value in the api connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.