Repository navigation
feat: Add support for additional fields in SignRequest - #919
Merged
Merged
Conversation
mwwoda
previously approved these changes
Mar 8, 2024
mwwoda
left a comment
Contributor
There was a problem hiding this comment.
Approved! Please also check comments
| expect(signRequest?.declinedRedirectUrl).to(equal(signParameters.declinedRedirectUrl)) | ||
| expect(signRequest?.parentFolder.id).to(equal(rootFolder.id)) | ||
| expect(signRequest?.signFiles?.files?.count).to(equal(2)) | ||
| // first signer is the sender with role final_copy_reader, second and third is the recipient with role signer |
Contributor
There was a problem hiding this comment.
Is it also possible to assert roles in this test?
| public let redirectUrl: String? | ||
| /// The URL that a signer will be redirect to after declining to sign a document. | ||
| public let declinedRedirectUrl: String? | ||
| /// This URL is specifically designed for signing documents within an HTML `iframe` tag. |
Contributor
There was a problem hiding this comment.
Extra space between "for" and "signing". I saw it's like this in the spec so maybe we shouldn't care about it.
Contributor
|
Also consider another name for this PR as it's adding much more than a single field |
signer_group_id field in SignRequestSignRequest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.