make integ test support ipv6 cluster #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0fd67e3 to
a2c0ceb
Compare
somnusfish
reviewed
Apr 15, 2022
somnusfish
reviewed
Apr 15, 2022
somnusfish
reviewed
Apr 15, 2022
| list_result | ||
| .instance_profiles | ||
| .as_ref() | ||
| .context("No instance profiles found")? | ||
| .iter() | ||
| .filter(|x| { |
There was a problem hiding this comment.
Is this from previous PR for the sg group?
There was a problem hiding this comment.
It's about finding instance profile not related to SG. The logic here is pretty strict and not suitable for different situations, so I think we don't need this anymore. Actually I have this code change in my NodeGroup PR, but I think it might be worth to add here.
somnusfish
reviewed
Apr 15, 2022
somnusfish
reviewed
Apr 15, 2022
1779710 to
5999eec
Compare
|
Push above address Lu's comments. |
etungsten
suggested changes
Apr 15, 2022
etungsten
reviewed
Apr 15, 2022
5999eec to
b2ff447
Compare
etungsten
approved these changes
Apr 15, 2022
somnusfish
reviewed
Apr 15, 2022
b2ff447 to
8ed8232
Compare
testing with ipv6 cluster, we need specify dns-ip setting on node userdata. So add a logic to find dns-ip from cluster info and transform to ideal format.
8ed8232 to
e803d0e
Compare
somnusfish
approved these changes
Apr 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing with ipv6 cluster, we need specify dns-ip setting on node
userdata. So add a logic to find dns-ip from cluster info and transform
to ideal format.
Issue number:
#186
Description of changes:
Meanwhile remove a strict and not generic filter to find instance profile.
Testing done:
Test with
brupop-ipv6andbrupop-ipv4cluster on brupop integration test account.ipv6
ipv4
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.