Skip to content

fix timeout in windows - #232

Closed
mmitti wants to merge 3 commits into
boostorg:developfrom
mmitti:patch-1
Closed

fix timeout in windows#232
mmitti wants to merge 3 commits into
boostorg:developfrom
mmitti:patch-1

Conversation

@mmitti

@mmitti mmitti commented Oct 24, 2019

Copy link
Copy Markdown
Contributor

Visual studio 2019 + Boost 1.71.0 + Windows 10 64bit

I use boost test with timeout(240) like below, it will timeout error.

BOOST_AUTO_TEST_CASE(TEST, *boost::unit_test::timeout(240)) {
    BOOST_TEST_INFO(1);
}

DueTime is 64bit, but static_cast<signed long int>(p_timeout) * 10 will 32bit and timeout value will overflow.

@raffienficiaud raffienficiaud added this to the 1.72 milestone Oct 26, 2019
@raffienficiaud raffienficiaud self-assigned this Oct 26, 2019
@raffienficiaud

Copy link
Copy Markdown
Member

Replaced with LONGLONG instead. Currently building in the branch topic/PR-232-fix-timeout-in-windows. Thanks!

@codecov

codecov Bot commented Nov 1, 2019

Copy link
Copy Markdown

Codecov Report

Merging #232 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #232   +/-   ##
========================================
  Coverage    55.78%   55.78%           
========================================
  Files          112      112           
  Lines         5890     5890           
  Branches      2380     2380           
========================================
  Hits          3286     3286           
  Misses         778      778           
  Partials      1826     1826
Impacted Files Coverage Δ
include/boost/test/impl/execution_monitor.ipp 38.02% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1bafb2...d26783b. Read the comment docs.

@raffienficiaud

Copy link
Copy Markdown
Member

Merged to master, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants