X3: Improve situation with move only types - #472
Merged
Kojoley merged 5 commits intoFeb 27, 2019
Conversation
Added tests for move only types in kleene, plus, list, and repeat parsers
Collaborator
|
Nice, as usual! |
Xeverous
reviewed
Feb 27, 2019
| inline bool push_back(Container& c, T&& val) | ||
| { | ||
| return push_back_container<Container>::call(c, std::move(val)); | ||
| return push_back_container<Container>::call(c, static_cast<T&&>(val)); |
Contributor
There was a problem hiding this comment.
What's the reason behind such changes? Reducing use of standard library (compile time)?
Collaborator
Author
There was a problem hiding this comment.
Removed surprising move of lvalue. And yes, std::forward is not zero cost in terms of compile time (also a surprising thing).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #465