X3: Perform attribute transformation before calling parse_rule - #456
Merged
Kojoley merged 1 commit intoFeb 8, 2019
Merged
Conversation
This will deal with linking problems when rule attribute type is not the same as the actual attribute type. It will not harm anyone as the transformation after parse_rule will just pass-through the attribute because it will be the same there. It will also do not alter rule_definition parsing so other usages are still valid.
Kojoley
added a commit
to Kojoley/spirit
that referenced
this pull request
Feb 8, 2019
After boostorg#456 `parse_rule` is always called with value of `rule::attribute_type&` type. By removing attribute type deduction we also will turn any possible bug in `transform_attribute` from a linkage to compile error. Fixes boostorg#454
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will deal with linking problems when rule attribute type is not the same
as the actual attribute type. It will not harm anyone as the transformation
after parse_rule will just pass-through the attribute because it will be the
same there. It will also do not alter rule_definition parsing so other usages
are still valid.
Refs #454, supersedes #347.