Support: Endian problems - #349
Merged
Merged
Conversation
Collaborator
Author
|
Also I am not sure why Spirit still does not use Boost.Endian (but I dislike that its io operators cannot be turned off, Spirit one does not have them). |
Kojoley
force-pushed
the
support-endian-problems
branch
from
January 4, 2018 19:45
692acb8 to
d80aad6
Compare
Collaborator
|
We should probably use Boost.Endian if we can. Does the io operators affect Spirit use? |
Collaborator
Author
|
It only includes |
Collaborator
Author
|
Boost.Endian is implemented with bit shifts on a passed type (only recently it started to cast signed to unsigned before shifting :O). Because of that float types are not supported and we cannot simply switch Karma and Qi to it. |
Kojoley
force-pushed
the
support-endian-problems
branch
4 times, most recently
from
March 7, 2019 20:04
0656dcb to
9d9b398
Compare
Kojoley
force-pushed
the
support-endian-problems
branch
from
March 7, 2019 20:06
9d9b398 to
9e64877
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BOOST_MINIMAL_INTEGER_COVER_OPERATORSBOOST_NO_IO_COVER_OPERATORSBOOST_SPIRIT_ENDIAN_NO_CTORSBOOST_SPIRIT_ENDIAN_DEFAULT_CONSTRUCTCloses #348