Switch visibility support to BOOST_SYMBOL_EXPORT. Refs #2114 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch sounds great ! The only thing I don't know is about exception visibility, I always expose them on windows, and that's why I use in my projects a special macros that expand to correct visibility on any platform but windows. |
8ccdcff to
3ace4a0
Compare
|
|
||
| namespace boost { namespace python | ||
| { | ||
| struct BOOST_PYTHON_DECL_FORWARD instance_holder; |
There was a problem hiding this comment.
this is the offending line that is a cause of #131
formiaczek
added a commit
to formiaczek/python
that referenced
this pull request
Aug 22, 2017
If a global visibility is set to 'hidden', importing modules that define classes without either 'noimport' or 'init' causes errors like: `ImportError: dynamic module does not define init function` This seems to be due to some, probably unintended changes from boostorg#1.
marv
added a commit
to marv/python
that referenced
this pull request
Sep 20, 2017
This was properly an oversight when switching to the BOOST_SYMBOL_* symbols from Boost.Config in commit 0224f54 (see boostorg#1) Since Boost.Config is already doing the differentiation between different platforms and compilers we can simplify this bit and just use BOOST_SYMBOL_EXPORT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while cleaning up my git svn mirror after the conversion. The patch switches Boost.Python to the common BOOST_SYMBOL_* macros from Boost.Config. This includes some minor cleanups for gcc which does not like visibility attributes on forward declarations. Testest with gcc and msvc-9.0