Skip to content

Fix interleaved_view factory using point<std::ptrdiff_t> for dimension #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mloskot merged 1 commit into from
Apr 23, 2020
Merged

Fix interleaved_view factory using point<std::ptrdiff_t> for dimension #487

mloskot merged 1 commit into from
Apr 23, 2020

Conversation

@sdebionne
Copy link
Contributor

@sdebionne sdebionne commented Apr 22, 2020 •
edited by mloskot
Loading

Description

Stick to the existing convention of ptrdiff_t and ensure it is used consistently across the existing code and new code.

References

https://cpplang.slack.com/archives/CSVT0STV2/p1587562275123700

Tasklist

  • Ensure all CI builds pass
  • Review and approve

mloskot
mloskot approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mloskot mloskot added cat/annoyance Not a bug, not a feature, but something that should be improved core boost/gil labels Apr 22, 2020
@mloskot mloskot added this to the Boost 1.74+ milestone Apr 22, 2020
@mloskot mloskot merged commit 19fdb4b into boostorg:develop Apr 23, 2020
@sdebionne sdebionne deleted the fix-interleaved-view-factory branch April 27, 2020 07:41
mloskot added a commit that referenced this pull request Jul 11, 2020
@mloskot
Initial merge of develop branch for Boost 1.74 release
0ac2e42 
* develop:
  Collect release notes for Boost 1.74
  Fix missing header in numeric/kernel.hpp to make it self-contained (#502)
  Use perfect forwading from apply_operation to visit (#491)
  Fix typos and replace mpl with mp11 in tutorial (#494)
  Implemented mechanism to reverse kernel_2d (#489)
  added missing const& in extend_boundary parameters (#490)
  Add initializing image constructor (#486)
  Fix interleaved_view factory using point<std::ptrdiff_t> for dimension (#487)
  RELEASES.md: Remove beta tag [ci skip]
  Replace Boost.Variant with Boost.Variant2 (#474)
  Fix error plane_view_t is not a class or namespace name (#481)
  Fix image constructor from other image (#477)
  Fix overflow in RGB to CMYK32 conversion (#470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mloskot mloskot mloskot approved these changes

Assignees

No one assigned

Labels

cat/annoyance Not a bug, not a feature, but something that should be improved core boost/gil

Projects

None yet

Milestone

Boost 1.74

Development

Successfully merging this pull request may close these issues.

2 participants

@sdebionne @mloskot