Skip to content

Make component source string replacements optional#76

Merged
ondrejbartas merged 2 commits intoblueberryapps:masterfrom
naturalethic:make-component-source-replacements-optional
Nov 4, 2016
Merged

Make component source string replacements optional#76
ondrejbartas merged 2 commits intoblueberryapps:masterfrom
naturalethic:make-component-source-replacements-optional

Conversation

@naturalethic
Copy link
Copy Markdown
Contributor

As the string replacements were causing invalid source when given a pure component such as

export default function MyComponent() {
  return <div>Hello</div>
}

and turning them off seems to work just fine, provide an option to do so.

Copy link
Copy Markdown
Contributor

@ondrejbartas ondrejbartas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naturalethic thank you for PR, can you add some comment to Readme pls?

@naturalethic
Copy link
Copy Markdown
Contributor Author

Ok I added some info there -- sort of hard to explain though because I don't know why you're doing that mangling in the first place.

@ondrejbartas
Copy link
Copy Markdown
Contributor

we were doing those replacements because some babel transpile files weren't able to be processed by react-docgen

@ondrejbartas ondrejbartas merged commit 05b994c into blueberryapps:master Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants