Fix nested relationship resolver comparison mode with one id set. #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there's a single id set, there's some short circuiting that goes in in the optimized implementation. That causes it to NOT add unnecessarliy to `requested_fields`. However, our comparison implementation was always adding a requested field, and consequently the payloads would be different in this case. That would trigger a log message indicating differences when there are in fact none. To fix this, we only need to add to `requested_fields` if `id_sets.size > 1`.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there's a single id set, there's some short circuiting that goes in in the optimized implementation. That causes it to NOT add unnecessarliy to
requested_fields. However, our comparison implementation was always adding a requested field, and consequently the payloads would be different in this case. That would trigger a log message indicating differences when there are in fact none.To fix this, we only need to add to
requested_fieldsifid_sets.size > 1.