Skip to content

Add all_of to GraphQL filtering schema alongside any_of #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ayousufi merged 1 commit into from
Apr 4, 2025
Merged

Add all_of to GraphQL filtering schema alongside any_of #355

ayousufi merged 1 commit into from
Apr 4, 2025

Conversation

@ayousufi
Copy link
Collaborator

@ayousufi ayousufi commented Mar 21, 2025 •
edited
Loading

This updates the schema to support top-level all_of filters, which has been a requested feature.

How Tested

  • update elasticgraph-schema_definition specs

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ayousufi ayousufi force-pushed the abdullah/all-of-schema branch from e175ff1 to f26a34d Compare March 24, 2025 09:13
@ayousufi ayousufi requested a review from myronmarston March 24, 2025 09:13
@ayousufi ayousufi force-pushed the abdullah/all-of-schema branch from f26a34d to 581404e Compare March 24, 2025 18:09
myronmarston
myronmarston requested changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@myronmarston myronmarston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good in general, but left a suggestion about the GraphQL docs.

@ayousufi ayousufi force-pushed the abdullah/all-of-schema branch from 71bbee0 to f56c519 Compare March 25, 2025 18:31
@ayousufi ayousufi requested a review from myronmarston March 25, 2025 18:31
@ayousufi ayousufi force-pushed the abdullah/all-of-schema branch 2 times, most recently from 7bb7667 to b5ba782 Compare March 31, 2025 23:06
@ayousufi ayousufi mentioned this pull request Apr 1, 2025
Merged
@ayousufi ayousufi force-pushed the abdullah/all-of-schema branch 2 times, most recently from b39b987 to ce08cb9 Compare April 1, 2025 20:36
myronmarston
myronmarston approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@myronmarston myronmarston left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ayousufi ayousufi force-pushed the abdullah/all-of-schema branch 3 times, most recently from d2e7b15 to 0f76b93 Compare April 4, 2025 21:16
@ayousufi ayousufi force-pushed the abdullah/all-of-schema branch from 0f76b93 to f651f46 Compare April 4, 2025 21:57
@ayousufi ayousufi merged commit 8502608 into main Apr 4, 2025
21 checks passed
@ayousufi ayousufi deleted the abdullah/all-of-schema branch April 4, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myronmarston myronmarston myronmarston approved these changes

@BrianSigafoos-SQ BrianSigafoos-SQ Awaiting requested review from BrianSigafoos-SQ BrianSigafoos-SQ is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ayousufi @CLAassistant @myronmarston