Skip to content
This repository was archived by the owner on Mar 7, 2026. It is now read-only.

Feature: declarations cleanup#1733

Merged
esden merged 15 commits intomainfrom
feature/decls-cleanup
Jan 18, 2024
Merged

Feature: declarations cleanup#1733
esden merged 15 commits intomainfrom
feature/decls-cleanup

Conversation

@dragonmux
Copy link
Copy Markdown
Member

@dragonmux dragonmux commented Jan 14, 2024

Detailed description

In this PR we aim to tie up some loose ends from the Meson build system's introduction, including the spate of new warnings, and some low-hanging UB that attempting LTO builds finds.

With these changes building normally should now be warnings-free. This also cleans up from the semihosting PRs by moving some straggler enums to the correct files as much as possible and fixing naming around them.

This fixes some more of the classes of warning targeted by the list in #1590

Your checklist for this pull request

Closing issues

@dragonmux dragonmux added Enhancement General project improvement Build system Build system labels Jan 14, 2024
@dragonmux dragonmux added this to the v2.0 release milestone Jan 14, 2024
@dragonmux dragonmux requested a review from esden January 14, 2024 07:00
@dragonmux dragonmux force-pushed the feature/decls-cleanup branch from a36e265 to e712744 Compare January 14, 2024 07:14
@dragonmux dragonmux mentioned this pull request Jan 14, 2024
43 tasks
@dragonmux dragonmux force-pushed the feature/decls-cleanup branch 2 times, most recently from fa4d708 to 4aaf963 Compare January 16, 2024 05:57
@dragonmux dragonmux force-pushed the feature/decls-cleanup branch from 4aaf963 to 441e95b Compare January 17, 2024 04:45
Copy link
Copy Markdown
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esden esden merged commit 441e95b into main Jan 18, 2024
@dragonmux dragonmux deleted the feature/decls-cleanup branch January 18, 2024 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Build system Build system Enhancement General project improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants