Fix: warning pedantic range expr#1603
Conversation
There was a problem hiding this comment.
This is looking good. There's one item that we have queries on that this touches but with that resolved, think this is good for merge.
Might we suggest, given this touches the Cortex-A and Cortex-M core support, that you give feature/arm-cortex-refactoring a look as that changes a fair whack to do with the Cortex code, as does feature/cortex-r-support which is built on top of the previously mentioned branch?
a0890a6 to
58a3a2c
Compare
dragonmux
left a comment
There was a problem hiding this comment.
Only have one comment that, once answered, leaves us happy to merge this. Great work! We look forward to finding a resolution to the enum problem too in a follow-up PR
range expressions in switch statements are non-standard
0x3 type is not defined, but the table did not account for its offset, meaning every type > 0x3 would should show a wrong, offset by 1 string, and type 8 would be out of bounds
3aa045a to
7136557
Compare
dragonmux
left a comment
There was a problem hiding this comment.
LGTM, we'll merge this once we've given it a test against some local parts to make sure things seem sane.
|
Looks good, seems to work well. Merging! |
Detailed description
This one was missed from the initial batch
Fix (some) warnings for
-WpedanticSee #1590 for context
Your checklist for this pull request
make PROBE_HOST=native)make PROBE_HOST=hosted)Closing issues