Fix: warning format

[perigoso]

Detailed description

Fix some warnings for -Wformat=2 -Wformat-overflow=2 -Wformat-signedness -Wformat-truncation

See #1590 for context

Your checklist for this pull request

• I've read the Code of Conduct
• I've read the guidelines for contributing to this repository
• It builds for hardware native (make PROBE_HOST=native)
• It builds as BMDA (make PROBE_HOST=hosted)
• I've tested it to the best of my ability
• My commit messages provide a useful short description of what the commits do

Closing issues

[dragonmux]

This is looking good, and particularly the fixes and cleanup in the HostIO code. It'll be nice to eliminate some more UB and get things better sorted out.

There are some changes we'd like to see made in the hostio_reply() code though and a query over format string changes involving enums. Hopefully we can find a suitable solution with the latter though.

[perigoso]

Reverted changes to enum type format specifiers, given the discussion in the review comments, for now let's reduce the scope of this PR and address the enum type issue separately

A note about format specifiers was added to HACKING.md, note that it was quickly thrown together and might not be optimal, suggestions are welcome

[amyspark]

Hey @perigoso ! @dragonmux showed me this PR, good job! Just found some grammar and typo nitpicks to share with you.

[perigoso]

Hey @amyspark, thank you for the review and suggestions! 😃

I made a small change to the way it's formatted after applying the the changes, since the "note" "directive" moved inline, the break in the middle felt out of place, so I removed it.

I think I'm happy with this as is.

[amyspark]

Going to poke @dragonmux to give it the final thumbs up!

[dragonmux]

LGTM. thank you Amy for the SPaG pass on the hacking guide change, and thank you Perigoso for putting together such a good PR that fixes so many subtle things.

Merging! The only change here that needs testing, we don't have the capability right now to test.. and that's the HostIO code. It looks correct though, so that's going to have to do with the community giving us feedback.

[dragonmux]

We'd probably just use %x for these, given integer promotion, but you are correct that technically we should be using the PRI macros everywhere on all fixed-width integer types, especially with raw types in new code being forbidden because using the raw types is non-portable for width constraints.

That said, this isn't a blocker, so we'll merge with this in.